Skip to content

Add missing error codes and their descriptions #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2023
Merged

Add missing error codes and their descriptions #77

merged 3 commits into from
Oct 5, 2023

Conversation

@NataliaIvakina
Copy link
Collaborator

@NataliaIvakina NataliaIvakina commented Oct 4, 2023

No description provided.

@NataliaIvakina
Copy link
Collaborator Author

NataliaIvakina commented Oct 4, 2023

Missing error codes in status code docs

@NataliaIvakina NataliaIvakina requested a review from Lojjs October 4, 2023 14:03
Lojjs
Lojjs reviewed Oct 4, 2023
View reviewed changes
Lojjs
Lojjs requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, 2 remaining things:

  1. Neo.TransientError.Database.DatabaseUnavailable should be called Neo.TransientError.General.DatabaseUnavailable instead

  2. I think one of the newly added ones should be removed again for now, see separate comment.

@NataliaIvakina NataliaIvakina requested a review from Lojjs October 5, 2023 08:16
Lojjs
Lojjs approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks :)

@NataliaIvakina NataliaIvakina merged commit e3f928b into neo4j:dev Oct 5, 2023
@NataliaIvakina NataliaIvakina deleted the dev-add-missing-info branch October 5, 2023 09:58
NataliaIvakina added a commit to NataliaIvakina/docs-status-codes that referenced this pull request Oct 5, 2023
@NataliaIvakina
Add missing error codes and their descriptions (neo4j#77)
7e76012
NataliaIvakina added a commit that referenced this pull request Oct 5, 2023
@NataliaIvakina
Add missing error codes and their descriptions (#77) (#78)
69df8f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lojjs Lojjs Lojjs approved these changes

@ali-ince ali-ince ali-ince left review comments

@renetapopova renetapopova Awaiting requested review from renetapopova

Assignees

No one assigned

Labels

cherry-pick this to 5.x dev The default branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NataliaIvakina @Lojjs @ali-ince