Fix client authentication #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- expire token after 10 minutes Co-authored-by: Paul Horn <paul.horn@neotechnology.com>
DarthMax
force-pushed
the
fix_authentication_timeout
branch
from
6160111 to
ef41872
Compare
Member
adamnsch
suggested changes
May 19, 2022
Contributor
adamnsch
left a comment
adamnsch
left a comment
There was a problem hiding this comment.
Looks good, just a bit confused about the change to the query runner interface
adamnsch
approved these changes
May 19, 2022
Contributor
adamnsch
left a comment
adamnsch
left a comment
There was a problem hiding this comment.
LGTM :) Just some minor nitpicks that I'd personally fix before merge, but I'll leave that for you to decide
Co-Authored-By: Adam Schill Collberg <adam.schill.collberg@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.