Allow creation of standalone sessions

[soerenreichardt]

No description provided.

[netlify]

✅ Deploy Preview for neo4j-graph-data-science-client canceled.

Name	Link
🔨 Latest commit	9ecde90
🔍 Latest deploy log	https://app.netlify.com/sites/neo4j-graph-data-science-client/deploys/67ee3c02eee3590008e78844

[DarthMax]

The code looks good but I wonder if we need to consider some implications to some functionality that requires a database. What happens if the user for example would run a write query?

[FlorentinD]

we only use the bolt query runner in this case?

[FlorentinD]

This would lead to run_cypher being forwarded to the session wouldnt it? I think we should throw a unsupported operation error or something in such cases

[soerenreichardt]

Good points, I implemented a dedicated query runner now that blocks all database related operations

[FlorentinD]

LGTM :)

only would like to have an integration test as well. Maybe in test_remote_graph_ops.py but with a graph construct.

• a changelog entry

[soerenreichardt]

only would like to have an integration test as well

To test what exactly? :) I don't see what an integration test would give us that the unit test didn't capture in this case.

[FlorentinD]

only would like to have an integration test as well

To test what exactly? :) I don't see what an integration test would give us that the unit test didn't capture in this case.

I was thinking of making sure its wired up correctly (i.e. such as the previous error in the query runner).

[FlorentinD]

thats accessed on graph projection .. makes me wonder if there is a bug for sessions in general as this database can be viewed as either the db database or the session database (which doesnt make sense as its fixed)

[soerenreichardt]

I think this is not a bug in sessions. The code that uses the db information looks like this:

        if len(info) == 0:
            raise ValueError(f"There is no projected graph named '{self.name()}'")
        if len(info) > 1:
            # for multiple dbs we can have the same graph name. But db + graph name is unique
            info = info[info["database"] == self._db]

So only when we are getting more than one result back from graph.list where we specify a graph name we will check the db. That could in theory be failing as we are using the database name from the db query runner, however on a session we cannot have the same graphName on multiple projections so we should be safe here 🤞.
We could do better though by maybe having a special Graph implementation for sessions?

[FlorentinD]

Alternatively we can split the database method into gds_database and db_database.

With its usage only on list this should never be an issue for the session case.

For sessions we anyway plan to rewrite quite a bit of the client and maybe we will endup with a different Graph implementation as well 🤔