Skip to content

Remove Node, Relationship and everything else #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2025
Merged

Remove Node, Relationship and everything else #6850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
947650a
initial refactor operations
a-alle Nov 19, 2025
8b00a15
Merge branch 'update-translation-layer' into cleanup
a-alle Nov 20, 2025
f67578e
remove Node, Relationship, and everything else
a-alle Nov 20, 2025
f62fdab
Merge branch 'update-translation-layer' into cleanup
a-alle Nov 20, 2025
fd5db6c
remove skip
a-alle Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 0 additions & 88 deletions packages/graphql/src/classes/GraphElement.ts
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions packages/graphql/src/classes/LimitDirective.test.ts
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions packages/graphql/src/classes/LimitDirective.ts
View file
Open in desktop

This file was deleted.

37 changes: 3 additions & 34 deletions packages/graphql/src/classes/Neo4jGraphQL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ import type { ExecutorConstructorParam, Neo4jGraphQLSessionConfig } from "./Exec
import { Executor } from "./Executor";
import type { Neo4jDatabaseInfo } from "./Neo4jDatabaseInfo";
import { getNeo4jDatabaseInfo } from "./Neo4jDatabaseInfo";
import type Node from "./Node";
import type Relationship from "./Relationship";
import { Neo4jGraphQLAuthorization } from "./authorization/Neo4jGraphQLAuthorization";
import { Neo4jGraphQLSubscriptionsCDCEngine } from "./subscription/Neo4jGraphQLSubscriptionsCDCEngine";
import { assertIndexesAndConstraints } from "./utils/asserts-indexes-and-constraints";
Expand All @@ -72,9 +70,6 @@ class Neo4jGraphQL {
private driver?: Driver;
private features: ContextFeatures;

private _nodes?: Node[];
private _relationships?: Relationship[];

private jwtFieldsMap?: Map<string, string>;

private schemaModel?: Neo4jGraphQLSchemaModel;
Expand Down Expand Up @@ -201,22 +196,6 @@ class Neo4jGraphQL {
});
}

private get nodes(): Node[] {
if (!this._nodes) {
throw new Error("You must await `.getSchema()` before accessing `nodes`");
}

return this._nodes;
}

private get relationships(): Relationship[] {
if (!this._relationships) {
throw new Error("You must await `.getSchema()` before accessing `relationships`");
}

return this._relationships;
}

/**
* Currently just merges all type definitions into a document. Eventual intention described below:
*
Expand Down Expand Up @@ -309,8 +288,6 @@ class Neo4jGraphQL {

const wrapResolverArgs: WrapResolverArguments = {
driver: this.driver,
nodes: this.nodes,
relationships: this.relationships,
schemaModel: this.schemaModel,
features: this.features,
authorization: this.authorization,
Expand Down Expand Up @@ -382,7 +359,7 @@ class Neo4jGraphQL {

private generateSchemaModel(document: DocumentNode): Neo4jGraphQLSchemaModel {
if (!this.schemaModel) {
return generateModel(document);
return generateModel(document, this.resolvers);
}
return this.schemaModel;
}
Expand Down Expand Up @@ -420,10 +397,9 @@ class Neo4jGraphQL {

this.schemaModel = this.generateSchemaModel(document);

const { nodes, relationships, typeDefs, resolvers } = makeAugmentedSchema({
const { typeDefs, resolvers } = makeAugmentedSchema({
document,
features: this.features,
userCustomResolvers: this.resolvers,
schemaModel: this.schemaModel,
complexityEstimatorHelper: this.complexityEstimatorHelper,
});
Expand All @@ -437,9 +413,6 @@ class Neo4jGraphQL {
});
}

this._nodes = nodes;
this._relationships = relationships;

const schema = makeExecutableSchema({
typeDefs,
resolvers,
Expand Down Expand Up @@ -490,10 +463,9 @@ class Neo4jGraphQL {

this.schemaModel = this.generateSchemaModel(document);

const { nodes, relationships, typeDefs, resolvers } = makeAugmentedSchema({
const { typeDefs, resolvers } = makeAugmentedSchema({
document,
features: this.features,
userCustomResolvers: this.resolvers,
subgraph,
schemaModel: this.schemaModel,
complexityEstimatorHelper: this.complexityEstimatorHelper,
Expand All @@ -510,9 +482,6 @@ class Neo4jGraphQL {
});
}

this._nodes = nodes;
this._relationships = relationships;

// TODO: Move into makeAugmentedSchema, add resolvers alongside other resolvers
const referenceResolvers = subgraph.getReferenceResolvers(this.schemaModel);

Expand Down
Loading