Improve error messages and objects around Transaction commit/rollback #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a temporary workaround until security work is completed in js driver
zhenlineo
approved these changes
Aug 26, 2019
Contributor
zhenlineo
left a comment
zhenlineo
left a comment
There was a problem hiding this comment.
Looks awesome. Just have a few small comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the error messages thrown in transaction commit / rollback cases. It also makes the thrown error objects to be actual
Neo4jErrorobjects.Updated related tests and re-enabled previously skipped tests.
Based on #479.