Skip to content

Tests: fix type hints #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Tests: fix type hints #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13d9849
Tests: fix type hints
robsdedude Apr 2, 2024
c37aac1
Complete fix
robsdedude Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/unit/async_/test_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,8 +1012,9 @@ async def test_execute_query_result_transformer(
driver = AsyncGraphDatabase.driver("bolt://localhost")
res: t.Any
async with driver as driver:
expected_transformer: t.Any = result_transformer
if result_transformer is Ellipsis:
result_transformer = AsyncResult.to_eager_result
expected_transformer = AsyncResult.to_eager_result
res_default: neo4j.EagerResult = await driver.execute_query("")
res = res_default
else:
Expand All @@ -1036,7 +1037,7 @@ async def test_execute_query_result_transformer(
session_executor_mock = session_mock._run_transaction
session_executor_mock.assert_awaited_once_with(
WRITE_ACCESS, TelemetryAPI.DRIVER, _work,
(mocker.ANY, mocker.ANY, result_transformer), {}
(mocker.ANY, mocker.ANY, expected_transformer), {}
)
assert res is session_executor_mock.return_value

Expand Down
5 changes: 3 additions & 2 deletions tests/unit/sync/test_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,8 +1011,9 @@ def test_execute_query_result_transformer(
driver = GraphDatabase.driver("bolt://localhost")
res: t.Any
with driver as driver:
expected_transformer: t.Any = result_transformer
if result_transformer is Ellipsis:
result_transformer = Result.to_eager_result
expected_transformer = Result.to_eager_result
res_default: neo4j.EagerResult = driver.execute_query("")
res = res_default
else:
Expand All @@ -1035,7 +1036,7 @@ def test_execute_query_result_transformer(
session_executor_mock = session_mock._run_transaction
session_executor_mock.assert_called_once_with(
WRITE_ACCESS, TelemetryAPI.DRIVER, _work,
(mocker.ANY, mocker.ANY, result_transformer), {}
(mocker.ANY, mocker.ANY, expected_transformer), {}
)
assert res is session_executor_mock.return_value

Expand Down