Support EagerResult from driver.execute_query() in from_neo4j()#335
Merged
Conversation
from_neo4j() now accepts neo4j.EagerResult (the default return type of driver.execute_query()). The implementation recovers the bolt hydration Graph directly from the entity back-references on record values, giving the same complete graph that Result.graph() would return — including start/end nodes not explicitly selected. A _collect_graph_entities() helper handles the fallback for results with no direct graph columns (paths, nested lists/dicts). Unit tests for the helper are in test_collect_graph_entities.py; an integration test for the full EagerResult path is added to test_neo4j.py.
robsdedude
reviewed
Apr 21, 2026
robsdedude
reviewed
Apr 21, 2026
* dont rebuild graph object and avoid using internal APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_neo4j() now accepts neo4j.EagerResult (the default return type of driver.execute_query()). The implementation recovers the bolt hydration Graph directly from the entity back-references on record values, giving the same complete graph that Result.graph() would return — including start/end nodes not explicitly selected.
A _collect_graph_entities() helper handles the fallback for results with no direct graph columns (paths, nested lists/dicts). Unit tests for the helper are in test_collect_graph_entities.py; an integration test for the full EagerResult path is added to test_neo4j.py.
Make sure: