Skip to content

Add integration testing for Snowflake notebooks#76

Merged
adamnsch merged 3 commits intomainfrom
snowflake-ci
Jan 27, 2025
Merged

Add integration testing for Snowflake notebooks#76
adamnsch merged 3 commits intomainfrom
snowflake-ci

Conversation

@adamnsch
Copy link
Collaborator

@adamnsch adamnsch commented Jan 27, 2025

Thank you for your contribution to the Graph Data Science Client project.

Before submitting this PR, please read Contributing to the Neo4j Ecosystem.

Make sure:

  • You signed the Neo4j CLA (Contributor License Agreement) so that we are allowed to ship your code in our library
  • Your contribution is covered by tests

Comment on lines +133 to +139
def test_simple() -> None:
simple_notebooks = ["simple-nvl-example.ipynb"]

def filter_func(notebook: str) -> bool:
return notebook in simple_notebooks

run_notebooks(filter_func)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont execute any notebook will it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not atm no :)

adamnsch and others added 2 commits January 27, 2025 11:23
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
@adamnsch adamnsch merged commit b5395ad into main Jan 27, 2025
7 checks passed
@adamnsch adamnsch deleted the snowflake-ci branch January 27, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants