cli push: Use os.walk instead of glob; upload with full path#8
Merged
soulshake merged 1 commit intoneocities:masterfrom Sep 28, 2019
Merged
cli push: Use os.walk instead of glob; upload with full path#8soulshake merged 1 commit intoneocities:masterfrom
soulshake merged 1 commit intoneocities:masterfrom
Conversation
In python 2.7 the recursive argument on glob is not supported, so this commit adds os.walk to discover all the files under a path. Passing os.path.split(file)[1] to nc.upload stripped the path resulting in a flattened file structure at the destination. This commit uses os.path.relpath to find what the destination path should be relative to dirc. Finally, this fixes a bug where files with names like DSC1234.JPG were not being uploaded because the check against the supExt list was case sensitive.
Collaborator
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python 2.7 the recursive argument on glob is not supported, so this commit adds
os.walkto discover all the files under a path.Passing
os.path.split(file)[1]tonc.uploadstripped the path resulting in a flattened file structure at the destination. This commit usesos.path.relpathto find what the destination path should be relative todirc.Finally, this fixes a bug where files with names like DSC1234.JPG were not being uploaded because the check against the
supExtlist was case sensitive.