Skip to content

Conversation

@shartte
Copy link
Collaborator

@shartte shartte commented Mar 19, 2025

Dependencies that include a classifier become "artifact dependencies" that bypass variant selection. In this case, the resulting artifacts do not inherit the attributes of their variants. The only way to get these artifacts to have attributes that would cause our artifact transform to apply is apparently to use a custom artifact type (and set it on the artifact dependencies).

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Mar 19, 2025

  • Publish PR to GitHub Packages

Last commit published: de1cbf3407f1ac0fa4252b73c09ba3dc00669a4f.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #242' // https://github.com/neoforged/ModDevGradle/pull/242
        url 'https://prmaven.neoforged.net/ModDevGradle/pr242'
        content {
            includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
        }
    }
}

Copy link
Member

@XFactHD XFactHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing :shipit:

@shartte shartte merged commit bf4f81f into main Mar 24, 2025
7 checks passed
@shartte shartte deleted the legacy-fix-srg-for-classifiers branch March 24, 2025 19:21
@neoforged-releases
Copy link

🚀 This PR has been released as ModDevGradle version 2.0.79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants