Add legacy forge repositories plugin #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technici4n
approved these changes
Jun 10, 2025
shartte
reviewed
Jun 10, 2025
shartte
reviewed
Jun 10, 2025
| public class LegacyRepositoriesPlugin implements Plugin<PluginAware> { | ||
| @Override | ||
| public void apply(PluginAware target) { | ||
| target.getPluginManager().apply(RepositoriesPlugin.class); |
Collaborator
There was a problem hiding this comment.
Hm, I wonder: Do we have to consider a case where someone applies the new repositories plugin to settings.gradle? Probably doesn't matter, since they couldn't have enabled the fail flag 🤔
Contributor
Author
There was a problem hiding this comment.
What do you mean? This should all just work with either repositories plugin applied to settings.
Co-authored-by: shartte <shartte@users.noreply.github.com>
|
🚀 This PR has been released as ModDevGradle version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260 with a dedicated legacy forge repositories plugin that works just as the normal one, applying the normal repositories plugin as well.