Conversation
Remove old and IDE* rules Move everything into the right space Fix dependencies Also deliver the globalconfig file dotfiles do not seem to be supported by nuspec corrections Revert "Remove old and IDE* rules" This reverts commit 65a9547. deprecated rule Add the exceptions back to the globalconfig Update rules Drop IDE0055 rule Adjust ruleset according recommended set + our overrides Use suggestion instead of info Somehow CS1591 was removed along the migration Suppress S2857 Has a confirmed FP that makes it unusable when using `nameof()` SonarSource/sonar-dotnet#6126 All explanations in the globalanalyzer file Get ready for release Refactor build files and update global configuration
drebrez
reviewed
Jun 14, 2023
Collaborator
drebrez
left a comment
drebrez
left a comment
There was a problem hiding this comment.
I'll test it with HBL solution
drebrez
approved these changes
Jun 23, 2023
Collaborator
drebrez
left a comment
drebrez
left a comment
There was a problem hiding this comment.
Code Analyzer durations with HBL solution
without cmdline 1 min
pipeline 2.5 min
v2.5.8 cmdline 8 min
pipeline 20-24 min
v3 rc0 cmdline 4.5 min
pipeline 13.5 min
v3 rc1 cmdline 5.5 min
pipeline 13.5 min
v3 rc2 cmdline 5.6 min
pipeline 12 min
v3 rc4 cmdline 5.5 min
pipeline 14 min
For me it looks good 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.