Skip to content

Empty configuration string should mean "Debug" #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neoscie merged 1 commit into from
Sep 27, 2023
Merged

Empty configuration string should mean "Debug" #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and adheres to a project-specific [Versioning](/README.md).

## [Unreleased]

### Fixed

- If build configuration is not passed explicitly, it should be like passing `Debug`

### Changed

- The XML documentation can be generated in all build configurations, there is no need to restrict it.

## [3.0.3] - 2023-07-20

### Fixed
Expand Down
7 changes: 6 additions & 1 deletion build/Neolution.CodeAnalysis.TestsRuleset.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<PropertyGroup Condition="'$(Configuration)' != 'Debug'">
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>

<PropertyGroup>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' != 'Debug'">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
Expand Down
7 changes: 6 additions & 1 deletion build/Neolution.CodeAnalysis.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<PropertyGroup Condition="'$(Configuration)' != 'Debug'">
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>

<PropertyGroup>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' != 'Debug'">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
Expand Down