Skip to content

Fix misplaced Configuration element in *.props file #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neoscie merged 4 commits into from
Sep 28, 2023
Merged

Fix misplaced Configuration element in *.props file #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20b5dbf
Release notifications should be publish to organization default channel
neoscie Sep 28, 2023
e7c6090
Fix misplaced `Configuration` element in `*.props` file
neoscie Sep 28, 2023
1642b6a
fat fingers
neoscie Sep 28, 2023
e56ef51
Fix also other props file
neoscie Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/cd-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,4 @@ jobs:
- uses: neolution-ch/action-release-notifier@v1
with:
slack-token: ${{ secrets.SLACK_RELEASE_NOTIFIER_TOKEN }}
# tech-announcements channel
slack-channel-ids: "C05DR8P010A"
slack-channel-ids: ${{ vars.SLACK_CHANNEL_ID_RELEASE_ANNOUNCEMENTS }}
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and adheres to a project-specific [Versioning](/README.md).

## [Unreleased]

### Fixed
- Misplaced `Configuration` element in `*.props` file in previous release, causing all projects to fail build

## [3.0.4] - 2023-09-27

### Fixed
Expand Down
3 changes: 1 addition & 2 deletions build/Neolution.CodeAnalysis.TestsRuleset.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>

<PropertyGroup>
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
3 changes: 1 addition & 2 deletions build/Neolution.CodeAnalysis.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>

<PropertyGroup>
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down