Skip to content

Track obsolete types with Analyzer, but don't break the build #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neoscie merged 4 commits into from
Sep 20, 2024
Merged

Track obsolete types with Analyzer, but don't break the build #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3d8bae
Track obsolete types with Analyzer, but don't break the build
neoscie Sep 19, 2024
9c4303d
Add comment in Changelog
neoscie Sep 19, 2024
5ea6d01
Actually change the rule
neoscie Sep 19, 2024
256875c
rephrase
neoscie Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and adheres to a project-specific [Versioning](/README.md).

## [Unreleased]

### Changed

- Updated `S1133` to `suggestion`, because while we do want deprecated code to be removed eventually, marking code as obsolete should not immediately break the build.

## [3.1.0] - 2024-09-19

### Fixed
Expand Down
4 changes: 4 additions & 0 deletions build/Neolution.CodeAnalysis.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,10 @@ dotnet_diagnostic.S3267.severity = suggestion
; Developers should be warned when they create disposable objects without disposing them
dotnet_diagnostic.CA2000.severity = warning

# S1133 Do not forget to remove this deprecated code someday.
; Deprecated code should eventually be removed, but it should not break the current build.
dotnet_diagnostic.S1133.severity = suggestion

# S107: Methods should not have too many parameters
dotnet_diagnostic.S107.severity = warning

Expand Down