Add flags for striped rows and clear search button in ReactDataTable#79
Merged
Add flags for striped rows and clear search button in ReactDataTable#79
Conversation
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces two optional flags to control the row striping and clear-search-button visibility in ReactDataTable.
- Add
isStripedprop to toggle striped rows (default:true) - Add
showClearSearchButtonprop to show/hide the clear search icon (default:true) - Wire props through component defaults and update changelog
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/ReactDataTable/ReactDataTableProps.ts | Define isStriped and showClearSearchButton props with JSDoc |
| src/lib/ReactDataTable/ReactDataTable.tsx | Destructure new props, apply striped={isStriped} and conditional clear button |
| CHANGELOG.md | Document new flags under the "Unreleased" section |
Comments suppressed due to low confidence (2)
src/lib/ReactDataTable/ReactDataTableProps.ts:112
- Update the JSDoc for
showClearSearchButton—it currently mentions a hover effect but should describe toggling the clear search button visibility.
* boolean flag to indicate if the table should have hover effect
src/lib/ReactDataTable/ReactDataTable.tsx:48
- Add unit or integration tests to verify that
isStripedcorrectly applies or removes the striping class, and thatshowClearSearchButtonshows or hides the clear icon as expected.
isStriped = true,
Michele-Masciave
approved these changes
Jun 3, 2025
manni497
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.