Color Picker Input | Fix warning and clear value#165
Merged
manni497 merged 39 commits intoneolution-ch:mainfrom Apr 16, 2026
Merged
Color Picker Input | Fix warning and clear value#165manni497 merged 39 commits intoneolution-ch:mainfrom
manni497 merged 39 commits intoneolution-ch:mainfrom
Conversation
commit: |
Michele-Masciave
changed the title
manni497
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX 1: usual MUI warning when value is not defined
if value is undefined
Fix the warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component.
if value is null
valueprop oninputshould not be null. Consider using an empty string to clear the component orundefinedfor uncontrolled components.FIX 2: color picker couldn't be cleared if value was already present (field.value not consistent with current watched value)