Skip to content

Commit 12898b6

Browse files
committed
Fix find_instances regression: Add missing Client mapping and Server implementation #8330
1 parent 51f1b1e commit 12898b6

3 files changed

Lines changed: 52 additions & 0 deletions

File tree

.github/ISSUE/issue-8330.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
---
2+
id: 8330
3+
title: '[Neural Link] Fix find_instances regression (Client mapping & OpenAPI)'
4+
state: OPEN
5+
labels:
6+
- bug
7+
- ai
8+
assignees:
9+
- tobiu
10+
createdAt: '2026-01-05T11:19:58Z'
11+
updatedAt: '2026-01-05T11:20:26Z'
12+
githubUrl: 'https://github.com/neomjs/neo/issues/8330'
13+
author: tobiu
14+
commentsCount: 0
15+
parentIssue: 8169
16+
subIssues: []
17+
subIssuesCompleted: 0
18+
subIssuesTotal: 0
19+
blockedBy: []
20+
blocking: []
21+
---
22+
# [Neural Link] Fix find_instances regression (Client mapping & OpenAPI)
23+
24+
Fix regression from previous session where `find_instances` was not fully integrated.
25+
26+
**Tasks:**
27+
1. **Client Mapping:** Add `find_instances` to the `serviceMap` in `src/ai/Client.mjs` to route requests to `InstanceService`.
28+
2. **OpenAPI Fix:** Investigate and fix the `openapi.yaml` file validation error that is preventing the Neural Link MCP server from starting.
29+
30+
## Activity Log
31+
32+
- 2026-01-05 @tobiu added the `bug` label
33+
- 2026-01-05 @tobiu added the `ai` label
34+
- 2026-01-05 @tobiu added parent issue #8169
35+
- 2026-01-05 @tobiu assigned to @tobiu
36+

ai/mcp/server/neural-link/services/InstanceService.mjs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,21 @@ class InstanceService extends Base {
2525
singleton: true
2626
}
2727

28+
/**
29+
* Finds instances matching a selector.
30+
* @param {Object} opts
31+
* @param {String} opts.sessionId
32+
* @param {Object} opts.selector
33+
* @param {String[]} [opts.returnProperties]
34+
* @returns {Promise<Object>}
35+
*/
36+
async findInstances({sessionId, selector, returnProperties}) {
37+
return await ConnectionService.call(sessionId, 'find_instances', {
38+
selector,
39+
returnProperties
40+
})
41+
}
42+
2843
/**
2944
* Retrieves properties from a specific instance by its ID.
3045
* @param {Object} opts

src/ai/Client.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ class Client extends Base {
9797
query_component : component,
9898
set_component : component,
9999

100+
find_instances : instance,
100101
get_instance_properties: instance,
101102
set_instance_properties: instance,
102103

0 commit comments

Comments
 (0)