Skip to content

Commit 178af92

Browse files
committed
refactor: Standardize render loop exit with canRender getter (#8795)
1 parent a2e0c29 commit 178af92

5 files changed

Lines changed: 14 additions & 5 deletions

File tree

apps/portal/canvas/Base.mjs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,15 @@ class Base extends NeoBase {
9393
}
9494
}
9595

96+
/**
97+
* Checks if the canvas is ready to render.
98+
* @returns {Boolean}
99+
*/
100+
get canRender() {
101+
let me = this;
102+
return !!(me.context && !me.isPaused)
103+
}
104+
96105
/**
97106
* Clears the graph state and stops the render loop.
98107
*/

apps/portal/canvas/HeaderCanvas.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class HeaderCanvas extends Base {
189189
render() {
190190
let me = this;
191191

192-
if (!me.context) {
192+
if (!me.canRender) {
193193
return
194194
}
195195

apps/portal/canvas/HomeCanvas.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,7 @@ class HomeCanvas extends Base {
689689
render() {
690690
let me = this;
691691

692-
if (!me.context || me.isPaused) {
692+
if (!me.canRender) {
693693
return
694694
}
695695

apps/portal/canvas/ServicesCanvas.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -908,8 +908,8 @@ class ServicesCanvas extends Base {
908908
render() {
909909
let me = this;
910910

911-
if (!me.context || me.isPaused) {
912-
return;
911+
if (!me.canRender) {
912+
return
913913
}
914914

915915
const

apps/portal/canvas/TicketCanvas.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ class TicketCanvas extends Base {
236236
render() {
237237
let me = this;
238238

239-
if (!me.context) {
239+
if (!me.canRender) {
240240
return
241241
}
242242

0 commit comments

Comments
 (0)