Skip to content

Commit 19fb457

Browse files
committed
#523 in progress
1 parent 8131212 commit 19fb457

4 files changed

Lines changed: 5 additions & 2 deletions

File tree

buildScripts/webpack/development/webpack.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,15 @@ if (config.examples) {
3636
}
3737

3838
plugins.push(new HtmlWebpackPlugin({
39-
chunks : ['main'],
39+
chunks : [],
4040
filename: path.resolve(processRoot, config.buildFolder) + value.output + 'index.html',
4141
template: path.resolve(neoPath, value.indexPath || 'buildScripts/webpack/index.ejs'),
4242
templateParameters: {
4343
appPath : value.output + 'app.js',
4444
bodyTag : value.bodyTag || config.bodyTag,
4545
basePath,
4646
environment : config.environment,
47+
mainPath : workerBasePath + 'main.js',
4748
themes : value.themes || "'neo-theme-light', 'neo-theme-dark'", // arrays are not supported as templateParameters
4849
title : value.title,
4950
useAmCharts : value.hasOwnProperty('useAmCharts') ? value.useAmCharts : false,

buildScripts/webpack/index.ejs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,6 @@
1919
workerBasePath: '<%= workerBasePath %>'
2020
});
2121
</script>
22+
<script src="<%= mainPath %>"></script>
2223
</body>
2324
</html>

docs/index.ejs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,6 @@
2020

2121
<script src="./resources/highlight/highlight.pack.js"></script>
2222
<script src="<%= basePath %>node_modules/highlightjs-line-numbers.js/dist/highlightjs-line-numbers.min.js"></script>
23+
<script src="<%= mainPath %>"></script>
2324
</body>
2425
</html>

src/worker/App.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class App extends Base {
6666
* @member {Number} countMainRemotes=5
6767
* @private
6868
*/
69-
countMainRemotes: 5,
69+
countMainRemotes: 4, // todo => dynamic for amCharts
7070
/**
7171
* todo: App needs to know how many singletons have remotes registered here to ensure a correct starting point
7272
* @member {Number} countVdomRemotes=1

0 commit comments

Comments
 (0)