Skip to content

Commit 1ffee33

Browse files
committed
Dev Mode: Main Thread Addon for Live Parsing #7131
1 parent 6410cdd commit 1ffee33

4 files changed

Lines changed: 2 additions & 341 deletions

File tree

.github/epic-string-based-templates.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,9 @@ An early proof-of-concept (PoC) already exists in the following files:
1111

1212
### 1. Dev Mode: Main Thread Addon for Live Parsing
1313

14-
**Description:**
15-
For development mode, we need an addon that can parse these HTML string templates on the fly within the browser. This allows for rapid development and testing without requiring a build step after every change.
14+
**Status:** Dropped
1615

17-
**Implementation Details:**
18-
- **Name:** `Neo.main.addon.HtmlStringToVdom`
19-
- **Method:**
20-
1. Use the native `DOMParser` to convert the HTML string into a standard DOM tree.
21-
2. Traverse the generated DOM tree and map it to a JSON structure that matches the Neo.mjs VDOM format.
22-
3. Ensure that any embedded logic or dynamic values from the template literal are correctly placed within the resulting VDOM for later processing by the framework.
16+
**Reason:** This approach was superseded by the in-worker parsing strategy (Sub-Task 4). The main thread addon would require an inefficient and slow worker roundtrip for parsing, while the in-worker approach is synchronous and significantly more performant for the zero-builds development mode. The addon and its related tests have been deleted to simplify the codebase.
2317

2418
### 2. Production Mode: Build-Time Parsing with `parse5`
2519

src/main/addon/HtmlStringToVdom.mjs

Lines changed: 0 additions & 178 deletions
This file was deleted.

test/siesta/siesta.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ project.plan(
8484
{
8585
group: 'functional',
8686
items: [
87-
'tests/functional/HtmlStringToVdom.mjs',
8887
'tests/functional/HtmlTemplateComponent.mjs',
8988
'tests/functional/Parse5Processor.mjs',
9089
'tests/functional/Button.mjs'

test/siesta/tests/functional/HtmlStringToVdom.mjs

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)