refactor: Use ensureStableIds in Button.Base to prevent prototype mutation (#8471)

Author: tobiu

src/button/Base.mjs

@@ -229,15 +229,13 @@ class Button extends Component {
     /**
      * Workaround fix for: https://github.com/neomjs/neo/issues/6659
      * Todo: inspect this further (we do not want to add fixed ids for all child nodes)
-     * Triggered after the id config got changed
-     * @param {String} value    The new value of the id config.
-     * @param {String} oldValue The old value of the id config.
+     * Ensures that the root VDOM node and its wrapper (if any) have stable, unique IDs
+     * derived from the component instance ID.
      * @protected
      */
-    afterSetId(value, oldValue) {
-        super.afterSetId(value, oldValue);
-
-        this.textNode.id = value + '__text'
+    ensureStableIds() {
+        super.ensureStableIds();
+        this.textNode.id = this.id + '__text'
     }
 
     /**

test/playwright/unit/button/Base.spec.mjs

@@ -117,4 +117,27 @@ test.describe('Neo.button.Base VDOM (Node.js)', () => {
 
         button.destroy();
     });
+
+    test('Prototype VDOM mutation check', async () => {
+        // Manually clean prototype to verify the fix or demonstrate the bug
+        // Note: We need to access the prototype from the class constructor
+        const protoVdom = Button.prototype._vdom;
+        if (protoVdom.cn[1].id) {
+            delete protoVdom.cn[1].id;
+        }
+
+        const button1 = Neo.create(Button, {
+            appName,
+            id: 'my-button-1',
+            text: 'Button 1'
+        });
+
+        // Instance should have it
+        expect(button1.textNode.id).toBe('my-button-1__text');
+
+        // Prototype should NOT have it (this will fail if bug is present)
+        expect(Button.prototype._vdom.cn[1].id).toBeUndefined();
+
+        button1.destroy();
+    });
 });