test: Fix Namespace Collisions in Unit Tests exposed by setupClass Guardrail (#8876)

Author: tobiu

src/Neo.mjs

@@ -813,6 +813,10 @@ If you intended to create custom logic, use the 'beforeGet${Neo.capitalize(key)}
          * Example: code.LivePreview running inside a dist/production app.
          */
         if (ns) {
+            if (Neo.config.unitTestMode) {
+                throw new Error('Namespace collision in unitTestMode for ' + proto.constructor.config.className)
+            }
+
             return ns
         }
 

test/playwright/unit/core/ClassConfigsAndFields.spec.mjs

@@ -11,7 +11,7 @@ class TestClass extends core.Base {
     fieldB = 2;
 
     static config = {
-        className: 'Neo.TestClass',
+        className: 'Test.Unit.Core.ClassConfigsAndFields.TestClass',
         configA_ : 3,
         configB_ : 4
     }
@@ -65,6 +65,10 @@ test.describe('ClassConfigsAndFields', () => {
 
     test('Neo default class fields inside constructors', () => {
         class NeoCtorTest extends core.Base {
+            static config = {
+                className: 'Test.Unit.Core.ClassConfigsAndFields.NeoCtorTest'
+            }
+
             fieldA = 1;
             fieldB = 2;
 
@@ -153,7 +157,7 @@ test.describe('ClassConfigsAndFields', () => {
 
     test('Class based class configs and fields', () => {
         const instance = Neo.create({
-            className: 'Neo.TestClass'
+            className: 'Test.Unit.Core.ClassConfigsAndFields.TestClass'
         });
 
         expect(instance.configA).toBe(4); // 1 + 3
@@ -164,7 +168,7 @@ test.describe('ClassConfigsAndFields', () => {
 
     test('Instance based class configs and fields', () => {
         const instance = Neo.create({
-            className: 'Neo.TestClass',
+            className: 'Test.Unit.Core.ClassConfigsAndFields.TestClass',
             fieldA   : 5,
             configA  : 6,
             configB  : 7,
@@ -177,7 +181,7 @@ test.describe('ClassConfigsAndFields', () => {
         expect(instance.fieldB).toBe(8);
 
         const instance2 = Neo.create({
-            className: 'Neo.TestClass',
+            className: 'Test.Unit.Core.ClassConfigsAndFields.TestClass',
             fieldB   : 8,
             configB  : 7,
             configA  : 6,
@@ -192,7 +196,7 @@ test.describe('ClassConfigsAndFields', () => {
 
     test('Dynamically changed class configs and fields', () => {
         const instance = Neo.create({
-            className: 'Neo.TestClass'
+            className: 'Test.Unit.Core.ClassConfigsAndFields.TestClass'
         });
 
         instance.set({
@@ -208,7 +212,7 @@ test.describe('ClassConfigsAndFields', () => {
         expect(instance.fieldB).toBe(8);
 
         const instance2 = Neo.create({
-            className: 'Neo.TestClass'
+            className: 'Test.Unit.Core.ClassConfigsAndFields.TestClass'
         });
 
         instance2.set({

test/playwright/unit/core/ClassSystem.spec.mjs

@@ -22,7 +22,7 @@ test.describe('ClassSystem', () => {
 
         class TestClass extends core.Base {
             static config = {
-                className: 'Neo.TestClass',
+                className: 'Test.Unit.Core.ClassSystem.TestClass',
                 a_       : valueA,
                 b_       : valueB
             }

test/playwright/unit/state/ProviderNestedDataConfigs.spec.mjs

@@ -15,7 +15,7 @@ import StateProvider   from '../../../../src/state/Provider.mjs';
 
 class MockComponent extends Component {
     static config = {
-        className: 'Mock.Component',
+        className: 'Test.Unit.State.ProviderNestedDataConfigs.MockComponent',
         appName  : 'test-app',
         user_    : null,
         userName_: null

test/playwright/unit/vdom/TreeBuilder.spec.mjs

@@ -19,8 +19,8 @@ import TreeBuilder    from '../../../../src/util/vdom/TreeBuilder.mjs';
 
 class MockComponent extends Component {
     static config = {
-        className: 'Test.MockComponent',
-        ntype: 'test-mock',
+        className: 'Test.Unit.Vdom.TreeBuilder.MockComponent',
+        ntype: 'test-unit-vdom-treebuilder-mock',
         _vdom: {tag: 'div'}
     }
 }

test/playwright/unit/vdom/VdomLifecycle.spec.mjs

@@ -25,8 +25,8 @@ Neo.applyDeltas = async () => {};
 
 class MockComponent extends Component {
     static config = {
-        className: 'Test.MockComponent',
-        ntype: 'test-mock',
+        className: 'Test.Unit.Vdom.VdomLifecycle.MockComponent',
+        ntype: 'test-unit-vdom-vdomlifecycle-mock',
         hideMode: 'removeDom',
         _vdom: {tag: 'div', cls: ['child']}
     }

test/playwright/unit/vdom/VdomMerging.spec.mjs

@@ -26,8 +26,8 @@ import VdomHelper         from '../../../../src/vdom/Helper.mjs';
 
 class TestContainer extends Container {
     static config = {
-        className: 'Test.Container',
-        ntype    : 'test-container',
+        className: 'Test.Unit.Vdom.VdomMerging.Container',
+        ntype    : 'test-unit-vdom-vdommerging-container',
         layout   : {ntype: 'vbox'},
         style    : {color: 'black'}
     }