Enhance Memory Core Health Check #7525

Author: tobiu

.github/ISSUE/ticket-mc-enhance-healthcheck.md

@@ -0,0 +1,22 @@
+---
+title: "Enhance Memory Core Health Check"
+labels: enhancement, AI
+---
+
+Parent epic: #7520
+GH ticket id: #7525
+
+**Phase:** 2
+**Assignee:** tobiu
+**Status:** Done
+
+## Description
+
+This ticket is to improve the `healthcheck` tool for the `memory-core` server to match the more comprehensive implementation of the `knowledge-base` server. This involves updating the `healthService.mjs` to check for the existence and status of both the `memories` and `summaries` collections, and updating the `openapi.yaml` to reflect the richer response schema.
+
+## Acceptance Criteria
+
+1.  The `buildHealthResponse` function in `ai/mcp/server/memory-core/services/healthService.mjs` is updated.
+2.  The health check now verifies the existence and document count of both the `memories` and `summaries` collections.
+3.  The `HealthCheckResponse` schema in `ai/mcp/server/memory-core/openapi.yaml` is updated to include the detailed database and collection status, matching the structure of the knowledge-base server's schema.
+4.  A successful health check call returns the new, richer status object.

ai/mcp/server/memory-core/openapi.yaml

@@ -452,11 +452,29 @@ components:
               type: object
               properties:
                 memories:
-                  type: string
-                  example: "neo-agent-memory"
+                  type: object
+                  properties:
+                    name:
+                      type: string
+                      example: "neo-agent-memory"
+                    exists:
+                      type: boolean
+                      example: true
+                    count:
+                      type: integer
+                      example: 1234
                 summaries:
-                  type: string
-                  example: "neo-agent-sessions"
+                  type: object
+                  properties:
+                    name:
+                      type: string
+                      example: "neo-agent-sessions"
+                    exists:
+                      type: boolean
+                      example: true
+                    count:
+                      type: integer
+                      example: 56
         version:
           type: string
           example: "1.0.0"

ai/mcp/server/memory-core/services/healthService.mjs

@@ -1,25 +1,58 @@
-import aiConfig      from '../../../../../buildScripts/ai/aiConfig.mjs';
 import chromaManager from './chromaManager.mjs';
 
 /**
- * Builds the payload returned by GET /healthcheck.
- * @returns {Promise<Object>}
+ * Verifies that the server is running and can successfully connect to the
+ * ChromaDB vector database, including checking for collection existence and counts.
+ * @returns {Promise<object>} A promise that resolves to the health check status object.
  */
 export async function buildHealthResponse() {
-    const {heartbeat, memoryCollection, summaryCollection} = await chromaManager.checkConnectivity();
+    try {
+        await chromaManager.client.heartbeat();
 
-    return {
-        status   : 'healthy',
-        timestamp: new Date().toISOString(),
-        database : {
-            host       : aiConfig.memory.host,
-            port       : aiConfig.memory.port,
-            heartbeat,
-            collections: {
-                memories : memoryCollection,
-                summaries: summaryCollection
+        let memoryCollection, summaryCollection;
+        let memoryCount = 0, summaryCount = 0;
+
+        try {
+            memoryCollection = await chromaManager.getMemoryCollection();
+            memoryCount = await memoryCollection.count();
+        } catch (e) {
+            // Collection does not exist, which is a valid state.
+        }
+
+        try {
+            summaryCollection = await chromaManager.getSummaryCollection();
+            summaryCount = await summaryCollection.count();
+        } catch (e) {
+            // Collection does not exist.
+        }
+
+        return {
+            status: "healthy",
+            database: {
+                connected: true,
+                collections: {
+                    memories: {
+                        name: aiConfig.memory.collectionName,
+                        exists: !!memoryCollection,
+                        count: memoryCount
+                    },
+                    summaries: {
+                        name: aiConfig.sessions.collectionName,
+                        exists: !!summaryCollection,
+                        count: summaryCount
+                    }
+                }
+            },
+            version: "1.0.0", // TODO: Should come from package.json
+            uptime: process.uptime()
+        };
+    } catch (error) {
+        return {
+            status: "unhealthy",
+            database: {
+                connected: false,
+                error: error.message
             }
-        },
-        uptime: process.uptime()
-    };
-}
+        };
+    }
+}