selection.*: remove all spots which increase the updateDepth #6309

Author: tobiu

src/selection/Model.mjs

@@ -110,9 +110,6 @@ class Model extends Base {
             NeoArray.remove(itemCollection, item);
 
             if (!silent) {
-                // We need a bigger depth, since grid.Container & table.Container use selection.Model as a  top-level config.
-                // In case the config would get moved to grid.View & table.View, we would not need it.
-                view.updateDepth = -1;
                 view.update();
 
                 me.fire('selectionChange', {
@@ -140,9 +137,6 @@ class Model extends Base {
             });
 
             if (!silent && items.length > 0) {
-                // We need a bigger depth, since grid.Container & table.Container use selection.Model as a  top-level config.
-                // In case the config would get moved to grid.View & table.View, we would not need it.
-                view.updateDepth = -1;
                 view.update()
             }
 
@@ -252,9 +246,6 @@ class Model extends Base {
             NeoArray.add(itemCollection, items);
 
             if (!view.silentSelect) {
-                // We need a bigger depth, since grid.Container & table.Container use selection.Model as a  top-level config.
-                // In case the config would get moved to grid.View & table.View, we would not need it.
-                view.updateDepth = -1;
                 view.update()
             }
 

src/selection/grid/BaseModel.mjs

@@ -22,48 +22,6 @@ class BaseModel extends Model {
     get dataFields() {
         return this.view.parent.columns.map(c => c.dataField)
     }
-
-    /**
-     * @param {Object} item
-     * @param {Boolean} [silent] true to prevent a vdom update
-     * @param {Object[]|String[]} itemCollection=this.items
-     * @param {String} [selectedCls]
-     */
-    deselect(item, silent, itemCollection=this.items, selectedCls) {
-        let {view} = this;
-
-        if (!silent) {
-            view.updateDepth = 2
-        }
-
-        super.deselect(item, silent, itemCollection, selectedCls)
-    }
-
-    /**
-     * @param {Boolean} [silent] true to prevent a vdom update
-     */
-    deselectAll(silent) {
-        let {view} = this;
-
-        if (!silent) {
-            view.updateDepth = 2
-        }
-
-        super.deselectAll(silent)
-    }
-
-    /**
-     * @param {Object} args
-     */
-    select(...args) {
-        let {view} = this;
-
-        if (!view.silentSelect) {
-            view.updateDepth = 2
-        }
-
-        super.select(...args)
-    }
 }
 
 export default Neo.setupClass(BaseModel);

src/selection/table/BaseModel.mjs

@@ -14,48 +14,6 @@ class BaseModel extends Model {
          */
         className: 'Neo.selection.table.BaseModel'
     }
-
-    /**
-     * @param {Object} item
-     * @param {Boolean} [silent] true to prevent a vdom update
-     * @param {Object[]|String[]} itemCollection=this.items
-     * @param {String} [selectedCls]
-     */
-    deselect(item, silent, itemCollection=this.items, selectedCls) {
-        let {view} = this;
-
-        if (!silent) {
-            view.updateDepth = 2
-        }
-
-        super.deselect(item, silent, itemCollection, selectedCls)
-    }
-
-    /**
-     * @param {Boolean} [silent] true to prevent a vdom update
-     */
-    deselectAll(silent) {
-        let {view} = this;
-
-        if (!silent) {
-            view.updateDepth = 2
-        }
-
-        super.deselectAll(silent)
-    }
-
-    /**
-     * @param {Object} args
-     */
-    select(...args) {
-        let {view} = this;
-
-        if (!view.silentSelect) {
-            view.updateDepth = 2
-        }
-
-        super.select(...args)
-    }
 }
 
 export default Neo.setupClass(BaseModel);

src/selection/table/CellRowModel.mjs

@@ -64,10 +64,7 @@ class CellRowModel extends CellModel {
 
         NeoArray.remove(me.selectedRowIds, rowId);
 
-        if (!silent) {
-            view.updateDepth = 2;
-            view.update()
-        }
+        !silent && view.update()
     }
 
     /**
@@ -132,10 +129,7 @@ class CellRowModel extends CellModel {
             me.selectedRowIds.push(id)
         }
 
-        if (!silent) {
-            view.updateDepth = 2;
-            view.update()
-        }
+        !silent && view.update()
     }
 
     /**