refactor(ai): Hybrid Vector DB: Decouple TextEmbeddingService and Eliminate Provider Fallbacks (#9719)

Author: tobiu

ai/mcp/server/memory-core/config.mjs

@@ -56,12 +56,6 @@ const defaultConfig = {
         clientId    : process.env.OAUTH_CLIENT_ID || null,
         clientSecret: process.env.OAUTH_CLIENT_SECRET || '',
     },
-    /**
-     * Provider to use for text embeddings ('gemini' or 'ollama')
-     * Used as the default fallback.
-     * @type {string}
-     */
-    embeddingProvider: process.env.EMBEDDING_PROVIDER || 'ollama',
     /**
      * Explicit override provider for the SQLite Native Database Engine.
      * @type {string}

ai/mcp/server/memory-core/managers/ChromaManager.mjs

@@ -147,7 +147,7 @@ class ChromaManager extends Base {
             generate   : async (texts) => {
                 // Pass arrays of texts sequentially or via promise.all to TextEmbeddingService
                 const {default: TextEmbeddingService} = await import('../services/TextEmbeddingService.mjs');
-                const provider                        = aiConfig.chromaEmbeddingProvider || aiConfig.embeddingProvider;
+                const provider                        = aiConfig.chromaEmbeddingProvider;
                 const vectors                         = await Promise.all(texts.map(text => TextEmbeddingService.embedText(text, provider)));
                 return vectors;
             },

ai/mcp/server/memory-core/services/HealthService.mjs

@@ -194,10 +194,10 @@ class HealthService extends Base {
         const providers = [aiConfig.modelProvider];
 
         if (aiConfig.engine === 'chroma' || aiConfig.engine === 'both') {
-            providers.push(aiConfig.chromaEmbeddingProvider || aiConfig.embeddingProvider);
+            providers.push(aiConfig.chromaEmbeddingProvider);
         }
         if (aiConfig.engine === 'neo' || aiConfig.engine === 'both') {
-            providers.push(aiConfig.neoEmbeddingProvider || aiConfig.embeddingProvider);
+            providers.push(aiConfig.neoEmbeddingProvider);
         }
 
         const needsGemini = providers.some(p => p === 'gemini');

ai/mcp/server/memory-core/services/TextEmbeddingService.mjs

@@ -40,7 +40,7 @@ class TextEmbeddingService extends Base {
     construct(config) {
         super.construct(config);
 
-        if (aiConfig.embeddingProvider === 'gemini' || aiConfig.chromaEmbeddingProvider === 'gemini' || aiConfig.neoEmbeddingProvider === 'gemini') {
+        if (aiConfig.chromaEmbeddingProvider === 'gemini' || aiConfig.neoEmbeddingProvider === 'gemini') {
             const apiKey = process.env.GEMINI_API_KEY;
             if (!apiKey) {
                 logger.warn('⚠️  [TextEmbeddingService] GEMINI_API_KEY not set. Semantic search features with Gemini will be unavailable.');
@@ -54,13 +54,13 @@ class TextEmbeddingService extends Base {
     /**
      * Creates an embedding vector for the provided text.
      * @param {String} text The text to embed.
-     * @param {String} [explicitProvider=null] The embedding provider to use, bypassing config.
+     * @param {String} explicitProvider The embedding provider to use.
      * @returns {Promise<number[]>}
      */
-    async embedText(text, explicitProvider = null) {
-        const provider = explicitProvider || aiConfig.embeddingProvider;
+    async embedText(text, explicitProvider) {
+        if (!explicitProvider) throw new Error('TextEmbeddingService.embedText requires an explicit provider argument');
 
-        if (provider === 'ollama') {
+        if (explicitProvider === 'ollama') {
             const { host, embeddingModel } = aiConfig.ollama;
             try {
                 const response = await fetch(`${host}/api/embeddings`, {