Skip to content

Commit 95d7367

Browse files
committed
fix: Remove obsolete GridColumnScrollPinning Addon & CSS Vars (#9490)
1 parent 3a37264 commit 95d7367

5 files changed

Lines changed: 3 additions & 188 deletions

File tree

resources/scss/src/grid/Body.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,6 @@
8888
z-index: 5;
8989
}
9090

91-
&.neo-locked-start {
92-
transform: translateX(var(--grid-locked-start-offset, 0px));
93-
}
94-
95-
&.neo-locked-end {
96-
transform: translateX(var(--grid-locked-end-offset, 0px));
97-
}
98-
9991
// selection.CellModel
10092
&.neo-selected {
10193
background-color: var(--grid-cellmodel-selected-cell-background-color) !important;

resources/scss/src/grid/header/Button.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@
4646
z-index: 5;
4747
}
4848

49-
&.neo-locked-start {
50-
transform: translateX(var(--grid-locked-start-offset, 0px));
51-
}
52-
53-
&.neo-locked-end {
54-
transform: translateX(var(--grid-locked-end-offset, 0px));
55-
}
56-
5749
&.neo-drag-over {
5850
background-image: linear-gradient(green, darkgreen);;
5951
}

src/grid/Container.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,6 @@ class GridContainer extends BaseContainer {
910910
if (me.bodyStart) me.bodyStart.createViewData();
911911
if (me.bodyEnd) me.bodyEnd.createViewData();
912912

913-
me.scrollManager?.updateColumnScrollPinningAddon()
914913
}
915914

916915
/**

src/grid/ScrollManager.mjs

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,10 @@ class ScrollManager extends Base {
9494
afterSetMounted(value, oldValue) {
9595
if (value) {
9696
this.dragScroll && this.updateDragScrollAddon(true);
97-
this.rowScrollPinning && this.updateRowScrollPinningAddon(true);
98-
this.updateColumnScrollPinningAddon()
97+
this.rowScrollPinning && this.updateRowScrollPinningAddon(true)
9998
} else if (oldValue) {
10099
this.updateDragScrollAddon(false);
101-
this.updateRowScrollPinningAddon(false);
102-
this.updateColumnScrollPinningAddon(false)
100+
this.updateRowScrollPinningAddon(false)
103101
}
104102
}
105103

@@ -123,11 +121,9 @@ class ScrollManager extends Base {
123121
if (oldValue && me.mounted) {
124122
me.dragScroll && me.updateDragScrollAddon(false, oldValue);
125123
me.rowScrollPinning && me.updateRowScrollPinningAddon(false, oldValue);
126-
me.updateColumnScrollPinningAddon(false, oldValue);
127124

128125
me.dragScroll && me.updateDragScrollAddon(true, value);
129-
me.rowScrollPinning && me.updateRowScrollPinningAddon(true, value);
130-
me.updateColumnScrollPinningAddon(value)
126+
me.rowScrollPinning && me.updateRowScrollPinningAddon(true, value)
131127
}
132128
}
133129

@@ -136,7 +132,6 @@ class ScrollManager extends Base {
136132
*/
137133
destroy(...args) {
138134
this.updateRowScrollPinningAddon(false);
139-
this.updateColumnScrollPinningAddon(false);
140135
super.destroy(...args)
141136
}
142137

@@ -199,29 +194,6 @@ class ScrollManager extends Base {
199194
me.gridContainer.headerToolbar.scrollLeft = me.scrollLeft
200195
}
201196

202-
/**
203-
* @param {Boolean} [active]
204-
* @param {String|null} [windowId=this.windowId]
205-
* @returns {Promise<void>}
206-
*/
207-
async updateColumnScrollPinningAddon(active, windowId=this.windowId) {
208-
let me = this;
209-
210-
active = active ?? (me.mounted && me.gridContainer?.hasLockedColumns);
211-
212-
let addon = await Neo.currentWorker.getAddon('GridColumnScrollPinning', windowId);
213-
214-
if (active) {
215-
addon.register({
216-
containerId: me.gridContainer.id,
217-
id : me.id,
218-
windowId
219-
})
220-
} else {
221-
addon.unregister({id: me.id, windowId})
222-
}
223-
}
224-
225197
/**
226198
* @param {Boolean} active
227199
* @param {String|null} [windowId=this.windowId]

src/main/addon/GridColumnScrollPinning.mjs

Lines changed: 0 additions & 140 deletions
This file was deleted.

0 commit comments

Comments
 (0)