Use once: true for related listeners #6573

Author: tobiu

src/calendar/view/SettingsContainer.mjs

@@ -159,16 +159,14 @@ class SettingsContainer extends Container {
     onCardIndexChange(data) {
         let me            = this,
             container     = data.item,
-            mainContainer = me.getMainContainer(),
-            listenerId;
+            mainContainer = me.getMainContainer();
 
         if (mainContainer) {
             if (Neo.isFunction(container.createContent) && container.items.length < 1) {
                 if (Neo.typeOf(mainContainer[`${container.flag}Component`]) !== 'NeoInstance') {
-                    listenerId = mainContainer.on('cardLoaded', () => {
-                        mainContainer.un('cardLoaded', listenerId);
+                    mainContainer.on('cardLoaded', () => {
                         me.timeout(30).then(() => {container.createContent()})
-                    })
+                    }, me, {once: true})
                 } else {
                     me.timeout(30).then(() => {container.createContent()})
                 }

src/component/Base.mjs

@@ -2662,8 +2662,7 @@ class Component extends Base {
      */
     updateVdom(resolve, reject) {
         let me                              = this,
-            {app, mounted, parentId, vnode} = me,
-            listenerId;
+            {app, mounted, parentId, vnode} = me;
 
         if (me.isVdomUpdating || me.silentVdomUpdate) {
             resolve && me.resolveUpdateCache.push(resolve);
@@ -2672,13 +2671,11 @@ class Component extends Base {
             if (!mounted && me.isConstructed && !me.hasRenderingListener && app?.rendering === true) {
                 me.hasRenderingListener = true;
 
-                listenerId = app.on('mounted', () => {
-                    app.un('mounted', listenerId);
-
+                app.on('mounted', () => {
                     me.timeout(50).then(() => {
                         me.vnode && me.updateVdom(resolve, reject)
                     })
-                })
+                }, me, {once: true})
             } else {
                 if (resolve && (!mounted || !vnode)) {
                     me.resolveUpdateCache.push(resolve)

src/component/Helix.mjs

@@ -546,12 +546,11 @@ class Helix extends Component {
             angle, item, matrixItems, transformStyle, vdomItem, c, s, x, y, z;
 
         if (!me.mounted) {
-            const listenerId = me.on('mounted', () => {
-                me.un('mounted', listenerId);
+            me.on('mounted', () => {
                 me.timeout(100).then(() => {
                     me.createItems(startIndex)
                 })
-            })
+            }, me, {once: true})
         } else {
             for (; i < len; i++) {
                 item = me.store.items[i];

src/controller/Component.mjs

@@ -45,18 +45,16 @@ class Component extends Base {
         super.construct(config);
 
         let me          = this,
-            {component} = me,
-            listenerId;
+            {component} = me;
 
         me.references = {};
 
         if (component.isConstructed) {
             me.onComponentConstructed()
         } else {
-            listenerId = component.on('constructed', () => {
-                component.un('constructed', listenerId);
+            component.on('constructed', () => {
                 me.onComponentConstructed()
-            })
+            }, me, {once: true})
         }
     }
 

src/plugin/Base.mjs

@@ -38,16 +38,14 @@ class Plugin extends Base {
         super.construct(config);
 
         let me      = this,
-            {owner} = me,
-            listenerId;
+            {owner} = me;
 
         if (owner.isConstructed) {
             me.onOwnerConstructed()
         } else {
-            listenerId = owner.on('constructed', () => {
-                owner.un('constructed', listenerId);
+            owner.on('constructed', () => {
                 me.onOwnerConstructed()
-            })
+            }, me, {once: true})
         }
 
         if (owner.mounted) {

src/selection/HelixModel.mjs

@@ -223,22 +223,19 @@ class HelixModel extends Model {
             isSelected = toggleSelection === false ? false : me.items.includes(itemId),
             items      = me.items,
             oldItems   = [...items],
-            deltas     = [],
-            listenerId;
+            deltas     = [];
 
         // a select() call can happen before the view is registered
         if (!view) {
             return;
         }
 
         if (!view.mounted) {
-            listenerId = view.on('mounted', () => {
-                view.un('mounted', listenerId);
-
+            view.on('mounted', () => {
                 me.timeout(300).then(() => {
                     me.select(itemId, toggleSelection)
                 })
-            })
+            }, me, {once: true})
         }
 
         if (me.singleSelect) {

src/tab/Container.mjs

@@ -524,7 +524,7 @@ class Container extends BaseContainer {
             i             = 0,
             len           = tabBar.items.length,
             index         = -1,
-            card, listenerId;
+            card;
 
         for (; i < len; i++) {
             if (tabBar.items[i].id === buttonId) {
@@ -537,10 +537,9 @@ class Container extends BaseContainer {
             card = cardContainer.items[index];
 
             if (me.vnode && !card.mounted) {
-                listenerId = card.on('mounted', () => {
-                    card.un('mounted', listenerId);
+                card.on('mounted', () => {
                     me.activeIndex = index
-                })
+                }, me, {once: true})
             } else {
                 me.activeIndex = index
             }