feat(ai): Implement Neural Link toJSON protocol for Client Services and Managers

tobiu · tobiu · commit aaeaa6e07533 · 2026-01-01T18:51:50.000+01:00
- Implement toJSON in manager.DragCoordinator - Implement toJSON in manager.Window - Refactor ComponentService to use toJSON protocol - Refactor DataService to use toJSON protocol - Refactor RuntimeService to use toJSON protocol - Update ai.client.Service.safeSerialize to prioritize toJSON Closes #8269 Closes #8270 Closes #8271 Closes #8272 Closes #8273
diff --git a/.github/.sync-metadata.json b/.github/.sync-metadata.json
@@ -1,6 +1,6 @@
 {
-  "lastSync": "2026-01-01T17:05:27.911Z",
-  "releasesLastFetched": "2026-01-01T17:05:29.039Z",
+  "lastSync": "2026-01-01T17:27:11.973Z",
+  "releasesLastFetched": "2026-01-01T17:27:13.415Z",
   "pushFailures": [],
   "issues": {
     "3789": {
@@ -13224,7 +13224,7 @@
       "path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8169.md",
       "closedAt": null,
       "updatedAt": "2025-12-28T13:36:59Z",
-      "contentHash": "333cbae3520653a989a8da40ec8b72f98cff87e7fd0d420ee188089059842ed8"
+      "contentHash": "1f2f782317eb13000e3acafd51eed670a22b905394b260e37fa2136b6247aeb5"
     },
     "8170": {
       "state": "CLOSED",
@@ -13441,7 +13441,7 @@
       "path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8200.md",
       "closedAt": null,
       "updatedAt": "2025-12-29T07:11:00Z",
-      "contentHash": "2cc570aea70c8dbc8ff92d57bbcb17fa8217e38b820afeed1217f89419c3e3c2"
+      "contentHash": "99f9ffe8c4c7f79432f53c2d0dc31fd681870e90b28b20ed51d223b298efff7b"
     },
     "8201": {
       "state": "CLOSED",
@@ -13911,6 +13911,41 @@
       "closedAt": "2026-01-01T17:04:17Z",
       "updatedAt": "2026-01-01T17:04:17Z",
       "contentHash": "73729320573de32ccd70acf7d21da6ca9416d3014d0169cc37c522683652b4a2"
+    },
+    "8269": {
+      "state": "OPEN",
+      "path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8269.md",
+      "closedAt": null,
+      "updatedAt": "2026-01-01T17:26:33Z",
+      "contentHash": "2caff4295928651a27a00efdbb69f405887e749f4c19557088d65e5515ffcf43"
+    },
+    "8270": {
+      "state": "OPEN",
+      "path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8270.md",
+      "closedAt": null,
+      "updatedAt": "2026-01-01T17:26:37Z",
+      "contentHash": "1665ec70c205bb6de8cb18629f10d3c53a5ca6ed8fa9b66e2f0175fa499491ef"
+    },
+    "8271": {
+      "state": "OPEN",
+      "path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8271.md",
+      "closedAt": null,
+      "updatedAt": "2026-01-01T17:26:40Z",
+      "contentHash": "10d78a9db31707f3a65661829314596e46b6ebe2a2be415f627967d06a9f7859"
+    },
+    "8272": {
+      "state": "OPEN",
+      "path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8272.md",
+      "closedAt": null,
+      "updatedAt": "2026-01-01T17:26:43Z",
+      "contentHash": "4c0033d8edf540dd5f2e0f8518a30b78e03b227d55d8e0ce43d109ed320b908a"
+    },
+    "8273": {
+      "state": "OPEN",
+      "path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8273.md",
+      "closedAt": null,
+      "updatedAt": "2026-01-01T17:26:47Z",
+      "contentHash": "a84094fac4285a81f1620fc1522600439d08e55314e767cdbaca38891c1349c4"
     }
   },
   "releases": {
diff --git a/.github/ISSUE/issue-8169.md b/.github/ISSUE/issue-8169.md
@@ -57,8 +57,11 @@ subIssues:
   - '[x] 8216 Fix Neural Link server startup crash due to missing startServer/stopServer methods'
   - '[x] 8222 Fix Neural Link Recovery: Exempt server control tools from health check gate'
   - '[x] 8223 Investigate and Fix get_component_tree Timeout'
+  - '[ ] 8271 [Neural Link] Refactor ComponentService to use toJSON protocol'
+  - '[ ] 8272 [Neural Link] Refactor DataService to use toJSON protocol'
+  - '[ ] 8273 [Neural Link] Refactor RuntimeService to use toJSON protocol'
 subIssuesCompleted: 36
-subIssuesTotal: 42
+subIssuesTotal: 45
 blockedBy: []
 blocking: []
 ---
@@ -135,4 +138,7 @@ Empower AI agents to "see" and "touch" the runtime application, moving beyond st
 - 2025-12-30 @tobiu added sub-issue #8216
 - 2025-12-30 @tobiu added sub-issue #8222
 - 2025-12-30 @tobiu added sub-issue #8223
+- 2026-01-01 @tobiu added sub-issue #8271
+- 2026-01-01 @tobiu added sub-issue #8272
+- 2026-01-01 @tobiu added sub-issue #8273
 
diff --git a/.github/ISSUE/issue-8200.md b/.github/ISSUE/issue-8200.md
@@ -56,8 +56,10 @@ subIssues:
   - '[x] 8266 [Neural Link] Implement toJSON in selection.table.CellColumnModel'
   - '[x] 8267 [Neural Link] Implement toJSON in selection.table.CellRowModel'
   - '[x] 8268 [Neural Link] Implement toJSON in selection.table.CellColumnRowModel'
+  - '[ ] 8269 [Neural Link] Implement toJSON in manager.DragCoordinator'
+  - '[ ] 8270 [Neural Link] Implement toJSON in manager.Window'
 subIssuesCompleted: 41
-subIssuesTotal: 41
+subIssuesTotal: 43
 blockedBy: []
 blocking: []
 ---
diff --git a/.github/ISSUE/issue-8269.md b/.github/ISSUE/issue-8269.md
@@ -0,0 +1,30 @@
+---
+id: 8269
+title: '[Neural Link] Implement toJSON in manager.DragCoordinator'
+state: OPEN
+labels:
+  - enhancement
+  - ai
+assignees: []
+createdAt: '2026-01-01T17:26:33Z'
+updatedAt: '2026-01-01T17:26:33Z'
+githubUrl: 'https://github.com/neomjs/neo/issues/8269'
+author: tobiu
+commentsCount: 0
+parentIssue: 8200
+subIssues: []
+subIssuesCompleted: 0
+subIssuesTotal: 0
+blockedBy: []
+blocking: []
+---
+# [Neural Link] Implement toJSON in manager.DragCoordinator
+
+Implement `toJSON` for the singleton `manager.DragCoordinator` to expose `activeTargetZone` and `sortZones` for AI inspection.
+
+## Activity Log
+
+- 2026-01-01 @tobiu added the `enhancement` label
+- 2026-01-01 @tobiu added the `ai` label
+- 2026-01-01 @tobiu added parent issue #8200
+
diff --git a/.github/ISSUE/issue-8270.md b/.github/ISSUE/issue-8270.md
@@ -0,0 +1,30 @@
+---
+id: 8270
+title: '[Neural Link] Implement toJSON in manager.Window'
+state: OPEN
+labels:
+  - enhancement
+  - ai
+assignees: []
+createdAt: '2026-01-01T17:26:37Z'
+updatedAt: '2026-01-01T17:26:37Z'
+githubUrl: 'https://github.com/neomjs/neo/issues/8270'
+author: tobiu
+commentsCount: 0
+parentIssue: 8200
+subIssues: []
+subIssuesCompleted: 0
+subIssuesTotal: 0
+blockedBy: []
+blocking: []
+---
+# [Neural Link] Implement toJSON in manager.Window
+
+Implement `toJSON` for the singleton `manager.Window`. This should serialize the collection of windows, ensuring each window object (`{appName, chrome, id, ...}`) is correctly serialized.
+
+## Activity Log
+
+- 2026-01-01 @tobiu added the `enhancement` label
+- 2026-01-01 @tobiu added the `ai` label
+- 2026-01-01 @tobiu added parent issue #8200
+
diff --git a/.github/ISSUE/issue-8271.md b/.github/ISSUE/issue-8271.md
@@ -0,0 +1,33 @@
+---
+id: 8271
+title: '[Neural Link] Refactor ComponentService to use toJSON protocol'
+state: OPEN
+labels:
+  - ai
+  - refactoring
+assignees: []
+createdAt: '2026-01-01T17:26:40Z'
+updatedAt: '2026-01-01T17:26:40Z'
+githubUrl: 'https://github.com/neomjs/neo/issues/8271'
+author: tobiu
+commentsCount: 0
+parentIssue: 8169
+subIssues: []
+subIssuesCompleted: 0
+subIssuesTotal: 0
+blockedBy: []
+blocking: []
+---
+# [Neural Link] Refactor ComponentService to use toJSON protocol
+
+Update `src/ai/client/ComponentService.mjs` to rely on the newly implemented `toJSON` methods for property extraction.
+*   `serializeComponent` should use `component.toJSON()` for base properties but maintain its own recursion logic to respect `maxDepth`.
+*   `getComponentProperty` should use `toJSON` if available.
+*   `queryComponent` should use `toJSON` for result mapping.
+
+## Activity Log
+
+- 2026-01-01 @tobiu added the `ai` label
+- 2026-01-01 @tobiu added the `refactoring` label
+- 2026-01-01 @tobiu added parent issue #8169
+
diff --git a/.github/ISSUE/issue-8272.md b/.github/ISSUE/issue-8272.md
@@ -0,0 +1,33 @@
+---
+id: 8272
+title: '[Neural Link] Refactor DataService to use toJSON protocol'
+state: OPEN
+labels:
+  - ai
+  - refactoring
+assignees: []
+createdAt: '2026-01-01T17:26:43Z'
+updatedAt: '2026-01-01T17:26:43Z'
+githubUrl: 'https://github.com/neomjs/neo/issues/8272'
+author: tobiu
+commentsCount: 0
+parentIssue: 8169
+subIssues: []
+subIssuesCompleted: 0
+subIssuesTotal: 0
+blockedBy: []
+blocking: []
+---
+# [Neural Link] Refactor DataService to use toJSON protocol
+
+Update `src/ai/client/DataService.mjs` to rely on `toJSON`.
+*   `getRecord`: Use `record.toJSON()` (already done, verify).
+*   `inspectStateProvider`: Use `provider.toJSON()`.
+*   `inspectStore`: Use `store.toJSON()`.
+
+## Activity Log
+
+- 2026-01-01 @tobiu added the `ai` label
+- 2026-01-01 @tobiu added the `refactoring` label
+- 2026-01-01 @tobiu added parent issue #8169
+
diff --git a/.github/ISSUE/issue-8273.md b/.github/ISSUE/issue-8273.md
@@ -0,0 +1,32 @@
+---
+id: 8273
+title: '[Neural Link] Refactor RuntimeService to use toJSON protocol'
+state: OPEN
+labels:
+  - ai
+  - refactoring
+assignees: []
+createdAt: '2026-01-01T17:26:47Z'
+updatedAt: '2026-01-01T17:26:47Z'
+githubUrl: 'https://github.com/neomjs/neo/issues/8273'
+author: tobiu
+commentsCount: 0
+parentIssue: 8169
+subIssues: []
+subIssuesCompleted: 0
+subIssuesTotal: 0
+blockedBy: []
+blocking: []
+---
+# [Neural Link] Refactor RuntimeService to use toJSON protocol
+
+Update `src/ai/client/RuntimeService.mjs`.
+*   `getDragState`: Use `DragCoordinator.toJSON()`.
+*   `getWindowInfo`: Use `WindowManager.toJSON()`.
+
+## Activity Log
+
+- 2026-01-01 @tobiu added the `ai` label
+- 2026-01-01 @tobiu added the `refactoring` label
+- 2026-01-01 @tobiu added parent issue #8169
+
diff --git a/src/ai/client/ComponentService.mjs b/src/ai/client/ComponentService.mjs
@@ -145,11 +145,7 @@ class ComponentService extends Service {
         }
 
         return {
-            components: matches.map(c => ({
-                id       : c.id,
-                className: c.className,
-                ntype    : c.ntype
-            }))
+            components: matches.map(c => c.toJSON())
         }
     }
 
@@ -194,15 +190,7 @@ class ComponentService extends Service {
     serializeComponent(component, maxDepth, currentDepth=1) {
         if (!component) return null;
 
-        const result = {
-            id       : component.id,
-            className: component.className,
-            ntype    : component.ntype
-        };
-
-        if (component.stateProvider) {
-            result.stateProviderId = component.stateProvider.id
-        }
+        const result = component.toJSON();
 
         if (maxDepth === -1 || currentDepth < maxDepth) {
             const children = Neo.manager.Component.getChildComponents(component);
diff --git a/src/ai/client/DataService.mjs b/src/ai/client/DataService.mjs
@@ -56,10 +56,7 @@ class DataService extends Service {
         const provider = Neo.get(providerId);
         if (!provider) throw new Error(`StateProvider not found: ${providerId}`);
 
-        return {
-            id  : provider.id,
-            data: provider.getHierarchyData()
-        }
+        return provider.toJSON()
     }
 
     /**
@@ -82,11 +79,7 @@ class DataService extends Service {
         }
 
         return {
-            id     : store.id,
-            count  : store.count,
-            model  : store.model?.className || 'N/A',
-            filters: store.exportFilters?.() || [],
-            sorters: store.exportSorters?.() || [],
+            ...store.toJSON(),
             items
         }
     }
diff --git a/src/ai/client/RuntimeService.mjs b/src/ai/client/RuntimeService.mjs
@@ -23,17 +23,7 @@ class RuntimeService extends Service {
         const dragCoordinator = Neo.manager?.DragCoordinator;
 
         if (dragCoordinator) {
-            return {
-                activeTargetZone: dragCoordinator.activeTargetZone ? {
-                    id       : dragCoordinator.activeTargetZone.id,
-                    sortGroup: dragCoordinator.activeTargetZone.sortGroup,
-                    windowId : dragCoordinator.activeTargetZone.windowId
-                } : null,
-                sortZones: Array.from(dragCoordinator.sortZones.entries()).map(([group, map]) => ({
-                    group,
-                    windows: Array.from(map.keys())
-                }))
-            }
+            return dragCoordinator.toJSON()
         }
 
         return {};
@@ -62,15 +52,7 @@ class RuntimeService extends Service {
         const windowManager = Neo.manager?.Window;
 
         if (windowManager) {
-            return {
-                windows: windowManager.items.map(win => ({
-                    id       : win.id,
-                    appName  : win.appName,
-                    chrome   : win.chrome,
-                    innerRect: win.innerRect,
-                    outerRect: win.outerRect
-                }))
-            }
+            return windowManager.toJSON()
         }
 
         return {windows: []};
diff --git a/src/ai/client/Service.mjs b/src/ai/client/Service.mjs
@@ -27,11 +27,7 @@ class Service extends Base {
         const type = Neo.typeOf(value);
 
         if (type === 'NeoInstance') {
-            return {
-                neoInstance: true,
-                id         : value.id,
-                className  : value.className
-            }
+            return value.toJSON()
         }
 
         if (type === 'Object') {
diff --git a/src/manager/DragCoordinator.mjs b/src/manager/DragCoordinator.mjs
@@ -166,6 +166,26 @@ class DragCoordinator extends Manager {
             }
         }
     }
+
+    /**
+     * @returns {Object}
+     */
+    toJSON() {
+        let me = this;
+
+        return {
+            className       : me.className,
+            activeTargetZone: me.activeTargetZone ? {
+                id       : me.activeTargetZone.id,
+                sortGroup: me.activeTargetZone.sortGroup,
+                windowId : me.activeTargetZone.windowId
+            } : null,
+            sortZones: Array.from(me.sortZones.entries()).map(([group, map]) => ({
+                group,
+                windows: Array.from(map.keys())
+            }))
+        }
+    }
 }
 
 export default Neo.setupClass(DragCoordinator);
diff --git a/src/manager/Window.mjs b/src/manager/Window.mjs

Original file line number	Diff line number	Diff line change
`@@ -56,10 +56,7 @@ class DataService extends Service {`
`56`	`56`	`const provider = Neo.get(providerId);`
`57`	`57`	if (!provider) throw new Error(`StateProvider not found: ${providerId}`);
`58`	`58`
`59`		`- return {`
`60`		`- id : provider.id,`
`61`		`- data: provider.getHierarchyData()`
`62`		`- }`
	`59`	`+ return provider.toJSON()`
`63`	`60`	`}`
`64`	`61`
`65`	`62`	`/**`
`@@ -82,11 +79,7 @@ class DataService extends Service {`
`82`	`79`	`}`
`83`	`80`
`84`	`81`	`return {`
`85`		`- id : store.id,`
`86`		`- count : store.count,`
`87`		`- model : store.model?.className \|\| 'N/A',`
`88`		`- filters: store.exportFilters?.() \|\| [],`
`89`		`- sorters: store.exportSorters?.() \|\| [],`
	`82`	`+ ...store.toJSON(),`
`90`	`83`	`items`
`91`	`84`	`}`
`92`	`85`	`}`