Skip to content

Commit ad471ec

Browse files
tobiutobiu
committed
docs(issue): Close tickets #8238, #8239, #8240 
1 parent e34a2ad commit ad471ec

5 files changed

Lines changed: 209 additions & 5 deletions

File tree

‎.github/.sync-metadata.json‎

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"lastSync": "2025-12-31T15:44:32.103Z",
3-
"releasesLastFetched": "2025-12-31T15:44:32.589Z",
2+
"lastSync": "2025-12-31T15:58:32.399Z",
3+
"releasesLastFetched": "2025-12-31T15:58:32.963Z",
44
"pushFailures": [],
55
"issues": {
66
"3789": {
@@ -13441,7 +13441,7 @@
1344113441
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8200.md",
1344213442
"closedAt": null,
1344313443
"updatedAt": "2025-12-29T07:11:00Z",
13444-
"contentHash": "6252ec813758321db85740aa7175519254b237b2340e2bdf3618e7b2e9f25c0f"
13444+
"contentHash": "99a661d14ebc5bdc0e19f448ee8c32836a7f3ea026bf358bcd771aff0f64b619"
1344513445
},
1344613446
"8201": {
1344713447
"state": "CLOSED",
@@ -13701,6 +13701,27 @@
1370113701
"closedAt": "2025-12-31T15:44:20Z",
1370213702
"updatedAt": "2025-12-31T15:44:20Z",
1370313703
"contentHash": "82de3554952acb9a9c03d9ba08b12d6e526d85820ef99a0bf245b3b0ed1ddb78"
13704+
},
13705+
"8238": {
13706+
"state": "CLOSED",
13707+
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8238.md",
13708+
"closedAt": "2025-12-31T15:57:57Z",
13709+
"updatedAt": "2025-12-31T15:57:57Z",
13710+
"contentHash": "e94c8145d976651c7cccdc562e810f67327d4831ff5c97c1838cf036e639774b"
13711+
},
13712+
"8239": {
13713+
"state": "CLOSED",
13714+
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8239.md",
13715+
"closedAt": "2025-12-31T15:58:09Z",
13716+
"updatedAt": "2025-12-31T15:58:09Z",
13717+
"contentHash": "431dfef22ffcfdc3f18880da784a35bf6ecc01df67d16e5fbb41c4ad30a394d8"
13718+
},
13719+
"8240": {
13720+
"state": "CLOSED",
13721+
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8240.md",
13722+
"closedAt": "2025-12-31T15:58:20Z",
13723+
"updatedAt": "2025-12-31T15:58:20Z",
13724+
"contentHash": "426e22a59357583d25e81327f9c6f626cf15248835ad6366e3d4b8abb6f1cbe7"
1370413725
}
1370513726
},
1370613727
"releases": {

‎.github/ISSUE/issue-8200.md‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ subIssues:
2626
- '[x] 8235 [Neural Link] Implement toJSON in layout.Card'
2727
- '[x] 8236 [Neural Link] Implement toJSON in layout.Form'
2828
- '[x] 8237 [Neural Link] Implement toJSON in layout.Cube'
29-
subIssuesCompleted: 11
30-
subIssuesTotal: 11
29+
- '[x] 8238 [Neural Link] Implement toJSON in collection.Base'
30+
- '[x] 8239 [Neural Link] Implement toJSON in collection.Filter'
31+
- '[x] 8240 [Neural Link] Implement toJSON in collection.Sorter'
32+
subIssuesCompleted: 14
33+
subIssuesTotal: 14
3134
blockedBy: []
3235
blocking: []
3336
---
@@ -81,4 +84,7 @@ Every class decides its own JSON representation. `JSON.stringify(instance)` auto
8184
- 2025-12-31 @tobiu added sub-issue #8235
8285
- 2025-12-31 @tobiu added sub-issue #8236
8386
- 2025-12-31 @tobiu added sub-issue #8237
87+
- 2025-12-31 @tobiu added sub-issue #8238
88+
- 2025-12-31 @tobiu added sub-issue #8239
89+
- 2025-12-31 @tobiu added sub-issue #8240
8490

‎.github/ISSUE/issue-8238.md‎

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
---
2+
id: 8238
3+
title: '[Neural Link] Implement toJSON in collection.Base'
4+
state: CLOSED
5+
labels:
6+
- enhancement
7+
- ai
8+
assignees:
9+
- tobiu
10+
createdAt: '2025-12-31T15:49:44Z'
11+
updatedAt: '2025-12-31T15:57:57Z'
12+
githubUrl: 'https://github.com/neomjs/neo/issues/8238'
13+
author: tobiu
14+
commentsCount: 1
15+
parentIssue: 8200
16+
subIssues: []
17+
subIssuesCompleted: 0
18+
subIssuesTotal: 0
19+
blockedBy: []
20+
blocking: []
21+
closedAt: '2025-12-31T15:57:57Z'
22+
---
23+
# [Neural Link] Implement toJSON in collection.Base
24+
25+
Implement the `toJSON` method in `src/collection/Base.mjs` to support the Neural Link serialization protocol.
26+
27+
It should return an object containing:
28+
- Properties from `super.toJSON()`
29+
- `count`
30+
- `keyProperty`
31+
- `sourceId`
32+
- `filters` (serialized via `toJSON` or `export`)
33+
- `sorters` (serialized via `toJSON` or `export`)
34+
35+
**Decision:** We will **NOT** serialize the full `items` array in `toJSON` to avoid performance issues with large datasets (e.g., buffered grids). Data inspection should be handled by specialized tools fetching data on demand.
36+
37+
## Comments
38+
39+
### @tobiu - 2025-12-31 15:57
40+
41+
**Input from Gemini:**
42+
43+
> ✦ I have implemented the `toJSON` method in `src/collection/Base.mjs`. It returns:
44+
> ```javascript
45+
> {
46+
> ...super.toJSON(),
47+
> count : this.count,
48+
> filters : this.filters.map(filter => filter.toJSON()),
49+
> keyProperty: this.keyProperty,
50+
> sorters : this.sorters.map(sorter => sorter.toJSON()),
51+
> sourceId : this.sourceId
52+
> }
53+
> ```
54+
> **Important:** We deliberately exclude `items` to avoid massive payloads. Data inspection should be handled via specialized tools or `getRecord` requests. Filters and sorters are recursively serialized.
55+
56+
## Activity Log
57+
58+
- 2025-12-31 @tobiu added the `enhancement` label
59+
- 2025-12-31 @tobiu added the `ai` label
60+
- 2025-12-31 @tobiu added parent issue #8200
61+
- 2025-12-31 @tobiu referenced in commit `e34a2ad` - "feat(collection): Implement toJSON in Collection, Filter, and Sorter for Neural Link (#8238, #8239, #8240)"
62+
- 2025-12-31 @tobiu assigned to @tobiu
63+
- 2025-12-31 @tobiu closed this issue
64+

‎.github/ISSUE/issue-8239.md‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
---
2+
id: 8239
3+
title: '[Neural Link] Implement toJSON in collection.Filter'
4+
state: CLOSED
5+
labels:
6+
- enhancement
7+
- ai
8+
assignees:
9+
- tobiu
10+
createdAt: '2025-12-31T15:50:34Z'
11+
updatedAt: '2025-12-31T15:58:09Z'
12+
githubUrl: 'https://github.com/neomjs/neo/issues/8239'
13+
author: tobiu
14+
commentsCount: 1
15+
parentIssue: 8200
16+
subIssues: []
17+
subIssuesCompleted: 0
18+
subIssuesTotal: 0
19+
blockedBy: []
20+
blocking: []
21+
closedAt: '2025-12-31T15:58:09Z'
22+
---
23+
# [Neural Link] Implement toJSON in collection.Filter
24+
25+
Implement the `toJSON` method in `src/collection/Filter.mjs` to support the Neural Link serialization protocol.
26+
27+
It should wrap the existing `export()` method or return a similar object:
28+
- `operator`
29+
- `property`
30+
- `value`
31+
32+
## Comments
33+
34+
### @tobiu - 2025-12-31 15:57
35+
36+
**Input from Gemini:**
37+
38+
> ✦ I have implemented the `toJSON` method in `src/collection/Filter.mjs`. It returns:
39+
> ```javascript
40+
> {
41+
> ...super.toJSON(),
42+
> disabled: this.disabled,
43+
> operator: this.operator,
44+
> property: this.property,
45+
> value : this.value
46+
> }
47+
> ```
48+
> This includes the full reactive state, independent of the `export()` method.
49+
50+
## Activity Log
51+
52+
- 2025-12-31 @tobiu added the `enhancement` label
53+
- 2025-12-31 @tobiu added the `ai` label
54+
- 2025-12-31 @tobiu added parent issue #8200
55+
- 2025-12-31 @tobiu referenced in commit `e34a2ad` - "feat(collection): Implement toJSON in Collection, Filter, and Sorter for Neural Link (#8238, #8239, #8240)"
56+
- 2025-12-31 @tobiu assigned to @tobiu
57+
- 2025-12-31 @tobiu closed this issue
58+

‎.github/ISSUE/issue-8240.md‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
---
2+
id: 8240
3+
title: '[Neural Link] Implement toJSON in collection.Sorter'
4+
state: CLOSED
5+
labels:
6+
- enhancement
7+
- ai
8+
assignees:
9+
- tobiu
10+
createdAt: '2025-12-31T15:50:45Z'
11+
updatedAt: '2025-12-31T15:58:20Z'
12+
githubUrl: 'https://github.com/neomjs/neo/issues/8240'
13+
author: tobiu
14+
commentsCount: 1
15+
parentIssue: 8200
16+
subIssues: []
17+
subIssuesCompleted: 0
18+
subIssuesTotal: 0
19+
blockedBy: []
20+
blocking: []
21+
closedAt: '2025-12-31T15:58:20Z'
22+
---
23+
# [Neural Link] Implement toJSON in collection.Sorter
24+
25+
Implement the `toJSON` method in `src/collection/Sorter.mjs` to support the Neural Link serialization protocol.
26+
27+
It should wrap the existing `export()` method or return a similar object:
28+
- `direction`
29+
- `property`
30+
31+
## Comments
32+
33+
### @tobiu - 2025-12-31 15:57
34+
35+
**Input from Gemini:**
36+
37+
> ✦ I have implemented the `toJSON` method in `src/collection/Sorter.mjs`. It returns:
38+
> ```javascript
39+
> {
40+
> ...super.toJSON(),
41+
> direction: this.direction,
42+
> property : this.property
43+
> }
44+
> ```
45+
> This includes the full reactive state, independent of the `export()` method.
46+
47+
## Activity Log
48+
49+
- 2025-12-31 @tobiu added the `enhancement` label
50+
- 2025-12-31 @tobiu added the `ai` label
51+
- 2025-12-31 @tobiu added parent issue #8200
52+
- 2025-12-31 @tobiu referenced in commit `e34a2ad` - "feat(collection): Implement toJSON in Collection, Filter, and Sorter for Neural Link (#8238, #8239, #8240)"
53+
- 2025-12-31 @tobiu assigned to @tobiu
54+
- 2025-12-31 @tobiu closed this issue
55+

0 commit comments

Comments
 (0)