Skip to content

Commit af58515

Browse files
committed
tab.Container: switching tabBarPosition does not correctly update the UI #7166
1 parent cbabf7c commit af58515

10 files changed

Lines changed: 23 additions & 24 deletions

File tree

src/component/Circle.mjs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ class Circle extends Component {
248248
* @protected
249249
*/
250250
afterSetMaxItems(value, oldValue) {
251-
if (oldValue && this.rendered) {
251+
if (oldValue && this.vnodeInitialized) {
252252
let me = this,
253253
frontEl = me.getFrontEl();
254254

@@ -289,7 +289,7 @@ class Circle extends Component {
289289
afterSetItemSize(value, oldValue) {
290290
let me = this;
291291

292-
if (oldValue && me.rendered) {
292+
if (oldValue && me.vnodeInitialized) {
293293
!me.collapsed && me.updateOuterCircle(true);
294294
me.updateItemPositions()
295295
}
@@ -302,7 +302,7 @@ class Circle extends Component {
302302
* @protected
303303
*/
304304
afterSetRotateX(value, oldValue) {
305-
oldValue && this.rendered && this.rotate()
305+
oldValue && this.vnodeInitialized && this.rotate()
306306
}
307307

308308
/**
@@ -312,7 +312,7 @@ class Circle extends Component {
312312
* @protected
313313
*/
314314
afterSetRotateY(value, oldValue) {
315-
oldValue && this.rendered && this.rotate()
315+
oldValue && this.vnodeInitialized && this.rotate()
316316
}
317317

318318
/**
@@ -322,7 +322,7 @@ class Circle extends Component {
322322
* @protected
323323
*/
324324
afterSetRotateZ(value, oldValue) {
325-
oldValue && this.rendered && this.rotate()
325+
oldValue && this.vnodeInitialized && this.rotate()
326326
}
327327

328328
/**
@@ -344,7 +344,7 @@ class Circle extends Component {
344344
* @protected
345345
*/
346346
afterSetSelectionModel(value, oldValue) {
347-
this.rendered && value.register(this);
347+
this.vnodeInitialized && value.register(this);
348348
}
349349

350350
/**

src/component/Gallery.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ class Gallery extends Component {
245245
afterSetMaxItems(value, oldValue) {
246246
let me = this;
247247

248-
if (value && me.rendered) {
248+
if (value && me.vnodeInitialized) {
249249
if (oldValue > value) {
250250
me.destroyItems(value, oldValue - value)
251251
} else {
@@ -310,7 +310,7 @@ class Gallery extends Component {
310310
len = Math.min(me.maxItems, me.store.items.length),
311311
view = me.getItemsRoot();
312312

313-
if (me.rendered) {
313+
if (me.vnodeInitialized) {
314314
me.refreshImageReflection();
315315

316316
me.timeout(50).then(() => {
@@ -338,7 +338,7 @@ class Gallery extends Component {
338338
*/
339339
afterSetSelectionModel(value, oldValue) {
340340
oldValue?.destroy();
341-
this.rendered && value.register(this)
341+
this.vnodeInitialized && value.register(this)
342342
}
343343

344344
afterSetTranslateX() {this.moveOrigin()}

src/component/Helix.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ class Helix extends Component {
348348
afterSetMaxItems(value, oldValue) {
349349
let me = this;
350350

351-
if (value && me.rendered) {
351+
if (value && me.vnodeInitialized) {
352352
if (oldValue > value) {
353353
me.destroyItems(value, oldValue - value)
354354
} else {
@@ -399,7 +399,7 @@ class Helix extends Component {
399399
* @protected
400400
*/
401401
afterSetSelectionModel(value, oldValue) {
402-
this.rendered && value.register(this)
402+
this.vnodeInitialized && value.register(this)
403403
}
404404

405405
/**
@@ -411,7 +411,7 @@ class Helix extends Component {
411411
afterSetUrl(value, oldValue) {
412412
let me = this;
413413

414-
if (me.rendered) {
414+
if (me.vnodeInitialized) {
415415
me.destroyItems();
416416
me.loadData()
417417
}

src/dialog/Base.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ class Dialog extends Panel {
269269
NeoArray.toggle(me.vdom.cls, 'neo-modal', value);
270270
me.update();
271271

272-
me.rendered && me.syncModalMask()
272+
me.vnodeInitialized && me.syncModalMask()
273273
}
274274

275275
/**
@@ -432,7 +432,7 @@ class Dialog extends Panel {
432432
}
433433

434434
// rendered outside the visible area
435-
await me.render(true);
435+
await me.initVnode(true);
436436

437437
let [dialogRect, bodyRect] = await me.waitForDomRect({id: [me.id, 'document.body']});
438438

src/form/field/Text.mjs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,8 +1579,7 @@ class Text extends Field {
15791579
}
15801580

15811581
/**
1582-
* Since triggers do not get rendered, assign the relevant props
1583-
* todo: this could be handled by component.Base
1582+
* Since triggers do not get vnodeInitialized, assign the relevant props
15841583
*/
15851584
updateTriggerVnodes() {
15861585
let me = this,
@@ -1593,8 +1592,8 @@ class Text extends Field {
15931592

15941593
trigger && Object.assign(trigger, {
15951594
vnode,
1596-
_rendered: true,
1597-
_mounted : true
1595+
_mounted : true,
1596+
_vnodeInitialized: true
15981597
})
15991598
})
16001599
}

src/grid/Body.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ class GridBody extends Component {
397397
* @protected
398398
*/
399399
afterSetSelectionModel(value, oldValue) {
400-
this.rendered && value.register(this)
400+
this.vnodeInitialized && value.register(this)
401401
}
402402

403403
/**

src/layout/Flexbox.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ class Flexbox extends Base {
295295
{container, prefix} = me,
296296
{wrapperCls} = container;
297297

298-
if (container?.rendered) {
298+
if (container?.vnodeInitialized) {
299299
NeoArray.remove(wrapperCls, prefix + propertyName + '-' + oldValue);
300300

301301
if (value !== null) {

src/list/Base.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ class List extends Component {
351351
* @protected
352352
*/
353353
afterSetSelectionModel(value, oldValue) {
354-
this.rendered && value.register(this)
354+
this.vnodeInitialized && value.register(this)
355355
}
356356

357357
/**

src/tab/BodyContainer.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ class BodyContainer extends Container {
1212
*/
1313
className: 'Neo.tab.BodyContainer',
1414
/**
15-
* @member {String[]} baseCls=['neo-container', 'neo-tab-body-container']
15+
* @member {String[]} baseCls=['neo-tab-body-container','neo-container']
1616
* @protected
1717
*/
18-
baseCls: ['neo-container', 'neo-tab-body-container']
18+
baseCls: ['neo-tab-body-container', 'neo-container']
1919
}
2020

2121
/**

src/table/Body.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class TableBody extends Component {
112112
* @protected
113113
*/
114114
afterSetSelectionModel(value, oldValue) {
115-
this.rendered && value.register(this)
115+
this.vnodeInitialized && value.register(this)
116116
}
117117

118118
/**

0 commit comments

Comments
 (0)