vdom.Helper: createDeltas() => enhance the logic for re-sorting arrays #3116

Author: tobiu

src/vdom/Helper.mjs

@@ -243,6 +243,9 @@ class Helper extends Base {
                         oldVnodeRoot,
                         parentId: movedNode.parentNode.id
                     });
+
+                    // see: https://github.com/neomjs/neo/issues/3116
+                    movedOldNode.parentNode.childNodes.splice(index, 0, movedOldNode);
                 } else if (!movedNode && movedOldNode) {
                     if (newVnode.id === movedOldNode.vnode.id) {
                         indexDelta = 0;

test/siesta/tests/VdomCalendar.mjs

@@ -43,8 +43,7 @@ StartTest(t => {
 
         t.isDeeplyStrict(deltas, [
             {action: 'moveNode', id: 'neo-event-2', index: 0, parentId: 'neo-column-1'},
-            {innerHTML: '06:00', id: 'neo-event-2__time'},
-            {action: 'moveNode', id: 'neo-event-1', index: 1, parentId: 'neo-column-1'} // todo: does not hurt, but not needed
+            {innerHTML: '06:00', id: 'neo-event-2__time'}
         ], 'deltas got created successfully');
 
         t.diag("Revert operation");
@@ -67,7 +66,6 @@ StartTest(t => {
 
         t.isDeeplyStrict(deltas, [
             {action: 'moveNode', id: 'neo-event-1', index: 0, parentId: 'neo-column-1'},
-            {action: 'moveNode', id: 'neo-event-2', index: 1, parentId: 'neo-column-1'}, // todo: does not hurt, but not needed
             {innerHTML: '10:00', id: 'neo-event-2__time'}
         ], 'deltas got created successfully');
     });

test/siesta/tests/VdomHelper.mjs

@@ -306,8 +306,8 @@ StartTest(t => {
         }, 'vnode got updated successfully');
 
         t.isDeeplyStrict(deltas, [
-            {action: 'moveNode', id: 'neo-vnode-3', index: 0, parentId: 'neo-vnode-1'},
-            {action: 'moveNode', id: 'neo-vnode-2', index: 2, parentId: 'neo-vnode-1'}
+            {action: 'moveNode', id: 'neo-vnode-3',  index: 0, parentId: 'neo-vnode-1'},
+            {action: 'moveNode', id: 'neo-button-1', index: 1, parentId: 'neo-vnode-1'}
         ], 'deltas got created successfully');
 
         vdom.cn.push(vdom.cn.shift()); // left shift
@@ -333,8 +333,7 @@ StartTest(t => {
 
         t.isDeeplyStrict(deltas, [
             {action: 'moveNode', id: 'neo-button-1', index: 0, parentId: 'neo-vnode-1'},
-            {action: 'moveNode', id: 'neo-vnode-2',  index: 1, parentId: 'neo-vnode-1'},
-            {action: 'moveNode', id: 'neo-vnode-3',  index: 2, parentId: 'neo-vnode-1'}
+            {action: 'moveNode', id: 'neo-vnode-2',  index: 1, parentId: 'neo-vnode-1'}
         ], 'deltas got created successfully');
 
         vdom.cn.unshift(vdom.cn.pop()); // right shift
@@ -359,9 +358,7 @@ StartTest(t => {
         }, 'vnode got updated successfully');
 
         t.isDeeplyStrict(deltas, [
-            {action: 'moveNode', id: 'neo-vnode-3',  index: 0, parentId: 'neo-vnode-1'},
-            {action: 'moveNode', id: 'neo-button-1', index: 1, parentId: 'neo-vnode-1'},
-            {action: 'moveNode', id: 'neo-vnode-2',  index: 2, parentId: 'neo-vnode-1'}
+            {action: 'moveNode', id: 'neo-vnode-3', index: 0, parentId: 'neo-vnode-1'}
         ], 'deltas got created successfully');
     });