Enhance build scripts for Windows compatibility #7796

Author: tobiu

buildScripts/createApp.mjs

@@ -1,15 +1,16 @@
-import chalk         from 'chalk';
-import { spawnSync } from 'child_process';
-import { Command }   from 'commander/esm.mjs';
-import envinfo       from 'envinfo';
-import fs            from 'fs-extra';
-import inquirer      from 'inquirer';
-import os            from 'os';
-import path          from 'path';
+import chalk       from 'chalk';
+import {spawnSync} from 'child_process';
+import {Command}   from 'commander/esm.mjs';
+import envinfo     from 'envinfo';
+import fs          from 'fs-extra';
+import inquirer    from 'inquirer';
+import os          from 'os';
+import path        from 'path';
 
 const
     __dirname    = path.resolve(),
     cwd          = process.cwd(),
+    nodeCmd      = os.platform().startsWith('win') ? 'node.exe' : 'node', // node binary based on OS
     requireJson  = path => JSON.parse(fs.readFileSync((path))),
     packageJson  = requireJson(path.join(__dirname, 'package.json')),
     insideNeo    = packageJson.name.includes('neo.mjs'),
@@ -274,7 +275,7 @@ if (programOpts.info) {
         fs.writeFileSync(appJsonPath, JSON.stringify(appJson, null, 4));
 
         if (mainThreadAddons.includes('HighlightJS')) {
-            const childProcess = spawnSync('node', [
+            const childProcess = spawnSync(nodeCmd, [
                 './buildScripts/copyFolder.mjs',
                 '-s',
                 path.resolve(neoPath, 'docs/resources'),

buildScripts/createAppMinimal.mjs

@@ -1,17 +1,19 @@
-import chalk          from 'chalk';
-import { spawnSync }  from 'child_process';
-import { Command }    from 'commander/esm.mjs';
-import envinfo        from 'envinfo';
-import fs             from 'fs-extra';
-import inquirer       from 'inquirer';
-import os             from 'os';
-import path           from 'path';
-
-const __dirname   = path.resolve(),
-    cwd           = process.cwd(),
-    requireJson   = path => JSON.parse(fs.readFileSync((path))),
-    packageJson   = requireJson(path.join(__dirname, 'package.json')),
-    insideNeo     = packageJson.name.includes('neo.mjs'),
+import chalk       from 'chalk';
+import {spawnSync} from 'child_process';
+import {Command}   from 'commander/esm.mjs';
+import envinfo     from 'envinfo';
+import fs          from 'fs-extra';
+import inquirer    from 'inquirer';
+import os          from 'os';
+import path        from 'path';
+
+const
+    __dirname    = path.resolve(),
+    cwd          = process.cwd(),
+    nodeCmd      = os.platform().startsWith('win') ? 'node.exe' : 'node', // node binary based on OS
+    requireJson  = path => JSON.parse(fs.readFileSync((path))),
+    packageJson  = requireJson(path.join(__dirname, 'package.json')),
+    insideNeo    = packageJson.name.includes('neo.mjs'),
     neoPath       = insideNeo ? './' : './node_modules/neo.mjs/',
     addonChoices  = fs.readdirSync(path.join(neoPath, '/src/main/addon')).map(item => item.slice(0, -4)),
     program       = new Command(),
@@ -319,7 +321,7 @@ export default Neo.setupClass(${className});
             fs.writeFileSync(appJsonPath, JSON.stringify(appJson, null, 4));
 
             if (mainThreadAddons.includes('HighlightJS')) {
-                spawnSync('node', [
+                spawnSync(nodeCmd, [
                     './buildScripts/copyFolder.mjs',
                     '-s',
                     path.resolve(neoPath, 'docs/resources'),

buildScripts/webpack/development/webpack.config.main.mjs

@@ -1,4 +1,5 @@
 import fs                from 'fs-extra';
+import os                from 'os';
 import path              from 'path';
 import webpack           from 'webpack';
 import WebpackHookPlugin from 'webpack-hook-plugin';
@@ -14,6 +15,7 @@ const cwd            = process.cwd(),
       copyFolder     = path.resolve(neoPath, 'buildScripts/copyFolder.mjs'),
       faFrom         = path.resolve(cwd, 'node_modules/@fortawesome/fontawesome-free'),
       faTo           = path.resolve(cwd, buildTarget.folder, 'resources/fontawesome-free'),
+      nodeCmd        = os.platform().startsWith('win') ? 'node.exe' : 'node',
       plugins        = [];
 
 let contextAdjusted = false;
@@ -53,7 +55,7 @@ export default {
             }
         }),
         new WebpackHookPlugin({
-            onBuildEnd: [`node ${copyFolder} -s ${faFrom} -t ${faTo}`]
+            onBuildEnd: [`${nodeCmd} ${copyFolder} -s ${faFrom} -t ${faTo}`]
         }),
         ...plugins
     ],

buildScripts/webpack/production/webpack.config.main.mjs

@@ -1,4 +1,5 @@
 import fs                from 'fs-extra';
+import os                from 'os';
 import path              from 'path';
 import webpack           from 'webpack';
 import WebpackHookPlugin from 'webpack-hook-plugin';
@@ -14,6 +15,7 @@ const cwd            = process.cwd(),
       copyFolder     = path.resolve(neoPath, 'buildScripts/copyFolder.mjs'),
       faFrom         = path.resolve(cwd, 'node_modules/@fortawesome/fontawesome-free'),
       faTo           = path.resolve(cwd, buildTarget.folder, 'resources/fontawesome-free'),
+      nodeCmd        = os.platform().startsWith('win') ? 'node.exe' : 'node',
       plugins        = [];
 
 let contextAdjusted = false;
@@ -52,7 +54,7 @@ export default {
             }
         }),
         new WebpackHookPlugin({
-            onBuildEnd: [`node ${copyFolder} -s ${faFrom} -t ${faTo}`]
+            onBuildEnd: [`${nodeCmd} ${copyFolder} -s ${faFrom} -t ${faTo}`]
         }),
         ...plugins
     ],