feat: Exclude DefaultConfig from webpack bundles & Modernize ESM Output (#8760)

Author: tobiu

buildScripts/webpack/development/webpack.config.main.mjs

@@ -12,7 +12,10 @@ const cwd            = process.cwd(),
       buildTarget    = requireJson(path.resolve(neoPath, 'buildScripts/webpack/development/buildTarget.json')),
       filenameConfig = requireJson(path.resolve(neoPath, 'buildScripts/webpack/json/build.json')),
       entry          = {main: path.resolve(neoPath, filenameConfig.mainInput)},
+      copyFile       = path.resolve(neoPath, 'buildScripts/copyFile.mjs'),
       copyFolder     = path.resolve(neoPath, 'buildScripts/copyFolder.mjs'),
+      defConfigFrom  = path.resolve(neoPath, 'src/DefaultConfig.mjs'),
+      defConfigTo    = path.resolve(cwd, buildTarget.folder, 'DefaultConfig.mjs'),
       faFrom         = path.resolve(cwd, 'node_modules/@fortawesome/fontawesome-free'),
       faTo           = path.resolve(cwd, buildTarget.folder, 'resources/fontawesome-free'),
       nodeCmd        = os.platform().startsWith('win') ? 'node.exe' : 'node',
@@ -42,6 +45,16 @@ export default {
     entry,
     target : 'web',
 
+    experiments: {
+        outputModule: true
+    },
+
+    externals: {
+        './DefaultConfig.mjs': './DefaultConfig.mjs'
+    },
+
+    externalsType: 'module',
+
     plugins: [
         // Only for the non workspace based build scope, we have to ignore workspace related addons.
         // This might be a fit for webpack.ContextExclusionPlugin, but I did not get it working.
@@ -55,15 +68,19 @@ export default {
             }
         }),
         new WebpackHookPlugin({
-            onBuildEnd: [`${nodeCmd} ${copyFolder} -s ${faFrom} -t ${faTo}`]
+            onBuildEnd: [
+                `${nodeCmd} ${copyFolder} -s ${faFrom} -t ${faTo}`,
+                `${nodeCmd} ${copyFile} -s ${defConfigFrom} -t ${defConfigTo}`
+            ]
         }),
         ...plugins
     ],
 
     output: {
         chunkFilename: 'chunks/main/[id].js',
         filename     : filenameConfig.mainOutput,
+        library      : {type: 'module'},
         path         : path.resolve(cwd, buildTarget.folder),
-        publicPath   : ''
+        publicPath   : 'auto'
     }
 };

buildScripts/webpack/production/webpack.config.main.mjs

@@ -13,8 +13,11 @@ const cwd            = process.cwd(),
       filenameConfig = requireJson(path.resolve(neoPath, 'buildScripts/webpack/json/build.json')),
       entry          = {main: path.resolve(neoPath, filenameConfig.mainInput)},
       copyFolder     = path.resolve(neoPath, 'buildScripts/copyFolder.mjs'),
+      defConfigFrom  = path.resolve(neoPath, 'src/DefaultConfig.mjs'),
+      defConfigTo    = path.resolve(cwd, buildTarget.folder, 'DefaultConfig.mjs'),
       faFrom         = path.resolve(cwd, 'node_modules/@fortawesome/fontawesome-free'),
       faTo           = path.resolve(cwd, buildTarget.folder, 'resources/fontawesome-free'),
+      minifyFile     = path.resolve(neoPath, 'buildScripts/minifyFile.mjs'),
       nodeCmd        = os.platform().startsWith('win') ? 'node.exe' : 'node',
       plugins        = [];
 
@@ -41,6 +44,16 @@ export default {
     entry,
     target: 'web',
 
+    experiments: {
+        outputModule: true
+    },
+
+    externals: {
+        './DefaultConfig.mjs': './DefaultConfig.mjs'
+    },
+
+    externalsType: 'module',
+
     plugins: [
         // Only for the non workspace based build scope, we have to ignore workspace related addons.
         // This might be a fit for webpack.ContextExclusionPlugin, but I did not get it working.
@@ -54,15 +67,19 @@ export default {
             }
         }),
         new WebpackHookPlugin({
-            onBuildEnd: [`${nodeCmd} ${copyFolder} -s ${faFrom} -t ${faTo}`]
+            onBuildEnd: [
+                `${nodeCmd} ${copyFolder} -s ${faFrom} -t ${faTo}`,
+                `${nodeCmd} ${minifyFile} ${defConfigFrom} ${defConfigTo}`
+            ]
         }),
         ...plugins
     ],
 
     output: {
         chunkFilename: 'chunks/main/[id].js',
         filename     : filenameConfig.mainOutput,
+        library      : {type: 'module'},
         path         : path.resolve(cwd, buildTarget.folder),
-        publicPath   : ''
+        publicPath   : 'auto'
     }
 };

src/main/DeltaUpdates.mjs

@@ -67,17 +67,9 @@ class DeltaUpdates extends Base {
     construct(config) {
         super.construct(config);
 
-        let {environment} = NeoConfig;
-
         if (NeoConfig.renderCountDeltas) {
             this.renderCountDeltas = true
         }
-
-        // We need different publicPath values for the main thread inside the webpack based dist envs,
-        // depending on the hierarchy level of the app entry point
-        if (environment === 'dist/development' || environment === 'dist/production') {
-            __webpack_require__.p = NeoConfig.basePath.substring(6)
-        }
     }
 
     /**