feat(memory-core): GraphService boot-time identity self-seed (#10232) (#10236)

* feat(memory-core): GraphService boot-time identity self-seed (#10232)

* revert(data): remove optional chaining from Neo.get in RecordFactory

* fix(memory-core): resolve test cache race for GraphService identity bootstrapping (#10236)

* chore(memory-core): cleanup stray patch artifacts from commit and update gitignore

---------

Co-authored-by: tobiu <tobiasuhlig78@gmail.com>

Author: neo-gemini-pro

.gitignore

@@ -119,3 +119,6 @@ test-results/
 
 # Autonomous AI Output files
 resources/content/sandman_handoff.md
+
+*.orig
+*.patch

ai/graph/identityRoots.mjs

@@ -0,0 +1,65 @@
+/**
+ * @summary Central definition of AgentIdentity and BroadcastSentinel root nodes for the Memory Core Graph.
+ *
+ * This shared list provides the definitive addressable identity surface for the A2A Mailbox
+ * substrate (#10139).
+ *
+ * It is used for both:
+ * 1. Boot-time self-seeding in `GraphService.initAsync` (#10232)
+ * 2. Explicit manual recovery via `ai/scripts/seedAgentIdentities.mjs`
+ */
+
+export const IDENTITIES = [
+    {
+        id: '@neo-opus-4-7',
+        type: 'AgentIdentity',
+        name: 'Claude Opus 4.7',
+        description: 'Anthropic Claude Opus version 4.7 Agent Identity',
+        properties: {
+            githubLogin: '@neo-opus-4-7',
+            displayName: 'Claude Opus 4.7',
+            modelFamily: 'claude',
+            accountType: 'agent',
+            createdAt: new Date().toISOString()
+        }
+    },
+    {
+        id: '@neo-gemini-3-1-pro',
+        type: 'AgentIdentity',
+        name: 'Gemini 3.1 Pro',
+        description: 'Google Gemini 3.1 Pro Agent Identity',
+        properties: {
+            githubLogin: '@neo-gemini-3-1-pro',
+            displayName: 'Gemini 3.1 Pro',
+            modelFamily: 'gemini',
+            accountType: 'agent',
+            createdAt: new Date().toISOString()
+        }
+    },
+    {
+        id: '@tobiu',
+        type: 'AgentIdentity',
+        name: 'Tobias Uhlig',
+        description: 'Human Owner',
+        properties: {
+            githubLogin: '@tobiu',
+            displayName: 'Tobias Uhlig',
+            modelFamily: null,
+            accountType: 'human',
+            createdAt: new Date().toISOString()
+        }
+    },
+    {
+        id: 'AGENT:*',
+        type: 'BroadcastSentinel',
+        name: 'Broadcast',
+        description: 'Mailbox broadcast sentinel. `SENT_TO` edges targeting this node fan out to all authenticated recipients per MailboxService.listMessages visibility rules. Must exist as a real graph node so GraphService.linkNodes FK-style guard does not cull broadcast edges — see #10174.',
+        properties: {
+            githubLogin: null,
+            displayName: 'Broadcast',
+            modelFamily: null,
+            accountType: 'sentinel',
+            createdAt: new Date().toISOString()
+        }
+    }
+];

ai/mcp/server/memory-core/services/GraphService.mjs

@@ -4,6 +4,7 @@ import logger       from '../logger.mjs';
 import Base         from '../../../../../src/core/Base.mjs';
 import CoreDatabase from '../../../../../ai/graph/Database.mjs';
 import SQLite       from '../../../../../ai/graph/storage/SQLite.mjs';
+import { IDENTITIES } from '../../../../../ai/graph/identityRoots.mjs';
 
 /**
  * @summary Service that manages the SQLite Knowledge Graph (Nodes and Edges).
@@ -88,7 +89,32 @@ class GraphService extends Base {
             }
             this.linkNodes('frontier', 'Neo-Master-Architecture', 'SYSTEM_TENET', 1.0);
 
-            // --- 2. FILE SYSTEM INGESTION (Differential Sync) ---
+            // --- 2. AGENT IDENTITY SUBSTRATE SEEDING (#10232) ---
+            // Eliminates the "seed → restart-again" recovery loop documented across sessions
+            // 0327771f, 15852d91, 8968b9f6, 24aa1fa1 (see #10232 body).
+            // Auto-provision identity roots at boot so bindAgentIdentity doesn't throw on fresh setups.
+            for (const identity of IDENTITIES) {
+                // We use getAdjacentNodes as a trigger for lazy-loading into the cache
+                this.db.getAdjacentNodes(identity.id, 'both');
+                
+                if (!this.db.nodes.has(identity.id)) {
+                    this.upsertNode(identity);
+                } else {
+                    // Defensive createdAt retention: Peek SQLite to preserve original timestamp
+                    const row = storage.db.prepare('SELECT data FROM Nodes WHERE id = ?').get(identity.id);
+                    if (row) {
+                        const rawData = JSON.parse(row.data);
+                        if (rawData.properties?.createdAt) {
+                            const preserved = {...identity, properties: {...identity.properties, createdAt: rawData.properties.createdAt}};
+                            this.upsertNode(preserved);
+                            continue;
+                        }
+                    }
+                    this.upsertNode(identity);
+                }
+            }
+
+            // --- 3. FILE SYSTEM INGESTION (Differential Sync) ---
             if (aiConfig.data.autoIngestFileSystem) {
                 logger.log('[GraphService] Bootstrapping FileSystem Ingestion Native Sync...');
                 const FileSystemIngestor = (await import('./FileSystemIngestor.mjs')).default;

ai/scripts/seedAgentIdentities.mjs

@@ -33,61 +33,7 @@
  */
 
 import { Memory_GraphService } from '../services.mjs';
-
-const IDENTITIES = [
-    {
-        id: '@neo-opus-4-7',
-        type: 'AgentIdentity',
-        name: 'Claude Opus 4.7',
-        description: 'Anthropic Claude Opus version 4.7 Agent Identity',
-        properties: {
-            githubLogin: '@neo-opus-4-7',
-            displayName: 'Claude Opus 4.7',
-            modelFamily: 'claude',
-            accountType: 'agent',
-            createdAt: new Date().toISOString()
-        }
-    },
-    {
-        id: '@neo-gemini-3-1-pro',
-        type: 'AgentIdentity',
-        name: 'Gemini 3.1 Pro',
-        description: 'Google Gemini 3.1 Pro Agent Identity',
-        properties: {
-            githubLogin: '@neo-gemini-3-1-pro',
-            displayName: 'Gemini 3.1 Pro',
-            modelFamily: 'gemini',
-            accountType: 'agent',
-            createdAt: new Date().toISOString()
-        }
-    },
-    {
-        id: '@tobiu',
-        type: 'AgentIdentity',
-        name: 'Tobias Uhlig',
-        description: 'Human Owner',
-        properties: {
-            githubLogin: '@tobiu',
-            displayName: 'Tobias Uhlig',
-            modelFamily: null,
-            accountType: 'human',
-            createdAt: new Date().toISOString()
-        }
-    },
-    {
-        id: 'AGENT:*',
-        type: 'BroadcastSentinel',
-        name: 'Broadcast',
-        description: 'Mailbox broadcast sentinel. `SENT_TO` edges targeting this node fan out to all authenticated recipients per MailboxService.listMessages visibility rules. Must exist as a real graph node so GraphService.linkNodes FK-style guard does not cull broadcast edges — see #10174.',
-        properties: {
-            githubLogin: null,
-            displayName: 'Broadcast',
-            modelFamily: null,
-            accountType: 'sentinel',
-            createdAt: new Date().toISOString()
-        }
-    }
-];
+import { IDENTITIES }          from '../graph/identityRoots.mjs';
 
 async function seed() {
     console.log('Bootstrapping Memory Graph Service...');

test/playwright/unit/ai/mcp/server/memory-core/services/GraphService.spec.mjs

@@ -536,4 +536,43 @@ test.describe('Neo.ai.mcp.server.memory-core.services.GraphService', () => {
 
         expect(ready).toBe(true);
     });
+
+    test('should auto-provision all identity roots at boot via initAsync', async () => {
+        // Guarantee pristine isolated boundary baseline natively
+        if (GraphService.db) {
+            GraphService.db.nodes.clear();
+            GraphService.db.edges.clear();
+            GraphService.db.vicinityLoadedNodes.clear();
+
+            if (GraphService.db.storage?.db) {
+                await GraphService.db.storage.clear();
+                GraphService.db.storage.db.exec('DELETE FROM GraphLog');
+                GraphService.db.lastSyncId = 0;
+            }
+        }
+
+        // Wipe the init promise and db to force complete re-initialization
+        GraphService._initPromise = null;
+        GraphService.db = null;
+
+        // Run the boot sequence
+        await GraphService.initAsync();
+
+        // Assert all four identities are present with correct types
+        const geminiPro = GraphService.getNode({id: '@neo-gemini-3-1-pro'});
+        expect(geminiPro).toBeTruthy();
+        expect(geminiPro.type).toBe('AgentIdentity');
+
+        const claudeOpus = GraphService.getNode({id: '@neo-opus-4-7'});
+        expect(claudeOpus).toBeTruthy();
+        expect(claudeOpus.type).toBe('AgentIdentity');
+
+        const tobiu = GraphService.getNode({id: '@tobiu'});
+        expect(tobiu).toBeTruthy();
+        expect(tobiu.type).toBe('AgentIdentity');
+
+        const broadcast = GraphService.getNode({id: 'AGENT:*'});
+        expect(broadcast).toBeTruthy();
+        expect(broadcast.type).toBe('BroadcastSentinel');
+    });
 });