grid.column.Base: renderer => allow string based value to map into a parent view controller #6638

Author: tobiu

examples/grid/nestedRecordFields/Viewport.mjs

@@ -60,7 +60,7 @@ class Viewport extends BaseViewport {
                 {dataField: 'user.lastname',  text: 'Lastname'},
                 {dataField: 'githubId',       text: 'Github Id'},
                 {dataField: 'date',           text: 'Date'},
-                {dataField: 'country',        text: 'Country',     renderer: 'up.countryRenderer'},
+                {dataField: 'country',        text: 'Country',     renderer: 'countryRenderer'},
                 {dataField: 'edit',           text: 'Edit Action', component: {
                     module : Button,
                     handler: 'editButtonHandler',
@@ -73,19 +73,6 @@ class Viewport extends BaseViewport {
             }
         }]
     }
-
-    /**
-     * @param {Object} data
-     */
-    countryRenderer({gridContainer, record}) {
-        let countryStore = gridContainer.getStateProvider().getStore('countries');
-
-        if (countryStore.getCount() > 0) {
-            return countryStore.get(record.country).name
-        }
-
-        return ''
-    }
 }
 
 export default Neo.setupClass(Viewport);

examples/grid/nestedRecordFields/ViewportController.mjs

@@ -18,6 +18,19 @@ class ViewportController extends Component {
      */
     dialog = null
 
+    /**
+     * @param {Object} data
+     */
+    countryRenderer({gridContainer, record}) {
+        let countryStore = gridContainer.getStateProvider().getStore('countries');
+
+        if (countryStore.getCount() > 0) {
+            return countryStore.get(record.country).name
+        }
+
+        return ''
+    }
+
     /**
      * @param {Object} data
      */

src/controller/Component.mjs

@@ -167,10 +167,10 @@ class Component extends Base {
      */
     parseConfig(component=this.component) {
         let me = this,
-            {handler, listeners, reference, validator} = component,
+            {handler, listeners, reference, renderer, validator} = component,
             eventHandler, handlerScope;
 
-        if (handler && typeof handler === 'string') {
+        if (handler && Neo.isString(handler)) {
             handlerScope = me.getHandlerScope(handler, component);
 
             // If the handler name was not resolved in the Component itself, bind it
@@ -192,7 +192,7 @@ class Component extends Base {
                         listeners[key].fn = handlerScope[eventHandler].bind(handlerScope)
                     }
                 } else {
-                    value.forEach(listener => {
+                    value?.forEach?.(listener => {
                         if (Neo.isObject(listener) && listener.hasOwnProperty('fn') && Neo.isString(listener.fn)) {
                             eventHandler = listener.fn;
                             handlerScope = me.getHandlerScope(eventHandler, component);
@@ -208,7 +208,17 @@ class Component extends Base {
             }
         });
 
-        if (Neo.isString(validator)) {
+        if (renderer && Neo.isString(renderer)) {
+            handlerScope = me.getHandlerScope(renderer);
+
+            if (!handlerScope) {
+                Logger.logError('Unknown renderer for', component.id, component)
+            } else {
+                component.renderer = handlerScope[renderer].bind(handlerScope)
+            }
+        }
+
+        if (validator && Neo.isString(validator)) {
             handlerScope = me.getHandlerScope(validator);
 
             if (!handlerScope) {

src/grid/Container.mjs

@@ -459,7 +459,9 @@ class GridContainer extends BaseContainer {
                 parent  : me,
                 windowId: me.windowId,
                 ...column
-            })
+            });
+
+            me.getController()?.parseConfig(columns[index])
         });
 
         me.items[0].items = headerButtons;

src/grid/column/Base.mjs

@@ -59,7 +59,8 @@ class Column extends Base {
      * @protected
      */
     beforeSetRenderer(value, oldValue) {
-        return resolveCallback(value, this).fn
+        // If no fn is found inside the parent tree, return the plain value for view controllers to match
+        return resolveCallback(value, this).fn || value
     }
 
     /**