Skip to content

Commit d96972b

Browse files
committed
data.RecordFactory: remove the ovPrefix_ config #6270
1 parent 6f10612 commit d96972b

1 file changed

Lines changed: 3 additions & 15 deletions

File tree

src/data/RecordFactory.mjs

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ class RecordFactory extends Base {
2020
* @protected
2121
*/
2222
className: 'Neo.data.RecordFactory',
23-
/**
24-
* The internal record prefix for original field values.
25-
* Only used in case the model has trackModifiedFields set to true.
26-
* @member {String} ovPrefix='ov_'
27-
*/
28-
ovPrefix: 'ov_',
2923
/**
3024
* @member {String} recordNamespace='Neo.data.record'
3125
*/
@@ -87,13 +81,6 @@ class RecordFactory extends Base {
8781
}
8882
};
8983

90-
// adding the original value of each field
91-
if (model.trackModifiedFields) {
92-
properties[instance.ovPrefix + field.name] = {
93-
value
94-
}
95-
}
96-
9784
Object.defineProperties(me, properties)
9885
}
9986
}
@@ -141,6 +128,7 @@ class RecordFactory extends Base {
141128
let me = this;
142129

143130
if (model.trackModifiedFields) {
131+
me[initialDataSymbol] = {};
144132
me.setInitial(config)
145133
}
146134

@@ -163,7 +151,7 @@ class RecordFactory extends Base {
163151
* @protected
164152
*/
165153
setInitial(fields) {
166-
instance.setRecordFields({fields, initialData: true, model, record: this})
154+
instance.setRecordFields({fields, initialData: true, model, record: this, silent: true})
167155
}
168156

169157
/**
@@ -398,7 +386,7 @@ class RecordFactory extends Base {
398386
value = instance.parseRecordValue(record, model.getField(key), value);
399387

400388
if (!Neo.isEqual(oldValue, value)) {
401-
instance.setRecordData({fieldName: key, model, record, value});
389+
instance.setRecordData({fieldName: key, initialData, model, record, value});
402390

403391
record._isModified = true;
404392
changedFields.push({name: key, oldValue, value})

0 commit comments

Comments
 (0)