Skip to content

Commit de02ab3

Browse files
committed
docs(issue): Close ticket #8232
1 parent 665b841 commit de02ab3

3 files changed

Lines changed: 36 additions & 12 deletions

File tree

.github/.sync-metadata.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"lastSync": "2025-12-31T15:10:02.030Z",
3-
"releasesLastFetched": "2025-12-31T15:10:02.576Z",
2+
"lastSync": "2025-12-31T15:12:42.616Z",
3+
"releasesLastFetched": "2025-12-31T15:12:43.133Z",
44
"pushFailures": [],
55
"issues": {
66
"3789": {
@@ -13441,7 +13441,7 @@
1344113441
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8200.md",
1344213442
"closedAt": null,
1344313443
"updatedAt": "2025-12-29T07:11:00Z",
13444-
"contentHash": "78bd2ac22ffa940f8e18f33dcee993b9d8a254db2fb651c3428817c0c55871d7"
13444+
"contentHash": "d401f96b809a855ba242e782c647fce18aaa56faea2b1bbca8793517c829b0a5"
1344513445
},
1344613446
"8201": {
1344713447
"state": "CLOSED",
@@ -13661,11 +13661,11 @@
1366113661
"contentHash": "4312b651d5d11839f93376df39e5085dde034395d32899661b21a95655e13a7a"
1366213662
},
1366313663
"8232": {
13664-
"state": "OPEN",
13664+
"state": "CLOSED",
1366513665
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8232.md",
13666-
"closedAt": null,
13667-
"updatedAt": "2025-12-31T15:08:43Z",
13668-
"contentHash": "c371300efad1ae78fbc25ef537da8dfae42fe4b62e96955be977ba984035132a"
13666+
"closedAt": "2025-12-31T15:12:18Z",
13667+
"updatedAt": "2025-12-31T15:12:18Z",
13668+
"contentHash": "9bfb2dad6be80bfccb9fdd79d355d92804821001bd4b905cb5dc80f47a124436"
1366913669
}
1367013670
},
1367113671
"releases": {

.github/ISSUE/issue-8200.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ subIssues:
2020
- '[x] 8225 [Neural Link] Implement toJSON in component.Base'
2121
- '[x] 8227 [Neural Link] Implement toJSON in button.Base'
2222
- '[x] 8228 [Neural Link] Implement toJSON in container.Base'
23-
- '[ ] 8232 [Neural Link] Implement toJSON in state.Provider'
24-
subIssuesCompleted: 5
23+
- '[x] 8232 [Neural Link] Implement toJSON in state.Provider'
24+
subIssuesCompleted: 6
2525
subIssuesTotal: 6
2626
blockedBy: []
2727
blocking: []
@@ -70,4 +70,5 @@ Every class decides its own JSON representation. `JSON.stringify(instance)` auto
7070
- 2025-12-31 @tobiu added sub-issue #8227
7171
- 2025-12-31 @tobiu added sub-issue #8228
7272
- 2025-12-31 @tobiu added sub-issue #8232
73+
- 2025-12-31 @tobiu referenced in commit `665b841` - "docs(issue): Update ticket state for #8200 and #8232"
7374

.github/ISSUE/issue-8232.md

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,24 @@
11
---
22
id: 8232
33
title: '[Neural Link] Implement toJSON in state.Provider'
4-
state: OPEN
4+
state: CLOSED
55
labels:
66
- enhancement
77
- ai
88
assignees:
99
- tobiu
1010
createdAt: '2025-12-31T15:08:13Z'
11-
updatedAt: '2025-12-31T15:08:43Z'
11+
updatedAt: '2025-12-31T15:12:18Z'
1212
githubUrl: 'https://github.com/neomjs/neo/issues/8232'
1313
author: tobiu
14-
commentsCount: 0
14+
commentsCount: 1
1515
parentIssue: 8200
1616
subIssues: []
1717
subIssuesCompleted: 0
1818
subIssuesTotal: 0
1919
blockedBy: []
2020
blocking: []
21+
closedAt: '2025-12-31T15:12:18Z'
2122
---
2223
# [Neural Link] Implement toJSON in state.Provider
2324

@@ -31,10 +32,32 @@ It should return an object containing:
3132
- `stores`: A mapped object where each store instance is serialized via its `toJSON()` method.
3233
- `windowId`: The associated window ID
3334

35+
## Comments
36+
37+
### @tobiu - 2025-12-31 15:11
38+
39+
**Input from Gemini:**
40+
41+
> ✦ I have implemented the `toJSON` method in `src/state/Provider.mjs`. It now returns the following structure:
42+
> ```javascript
43+
> {
44+
> ...super.toJSON(),
45+
> component: me.component?.id,
46+
> data : me.data,
47+
> parent : me.parent?.id,
48+
> stores : { /* mapped stores toJSON() */ },
49+
> windowId : me.windowId
50+
> }
51+
> ```
52+
> This enables proper serialization for the Neural Link, including recursive serialization of stores.
53+
3454
## Activity Log
3555
3656
- 2025-12-31 @tobiu added the `enhancement` label
3757
- 2025-12-31 @tobiu added the `ai` label
3858
- 2025-12-31 @tobiu added parent issue #8200
3959
- 2025-12-31 @tobiu assigned to @tobiu
60+
- 2025-12-31 @tobiu referenced in commit `2e9a550` - "feat(state): Implement toJSON in Neo.state.Provider for Neural Link serialization (#8232)"
61+
- 2025-12-31 @tobiu referenced in commit `665b841` - "docs(issue): Update ticket state for #8200 and #8232"
62+
- 2025-12-31 @tobiu closed this issue
4063

0 commit comments

Comments
 (0)