Skip to content

Commit de02f0a

Browse files
committed
feat: Migrate Sparkline Renderer to src/canvas & Enforce Defaults (#8955)
1 parent e2907a5 commit de02f0a

4 files changed

Lines changed: 11 additions & 10 deletions

File tree

apps/devrank/view/GridContainer.mjs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,6 @@ class GridContainer extends BaseGridContainer {
105105
text : 'Activity (15y)',
106106
width : 160,
107107
type : 'sparkline',
108-
rendererClassName : 'DevRank.canvas.Sparkline',
109-
rendererImportPath: 'apps/devrank/canvas/Sparkline.mjs',
110108
component : ({record}) => {
111109
const data = [];
112110
// Iterate from 2010 to 2025
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import Base from '../../../src/core/Base.mjs';
1+
import Base from '../../src/core/Base.mjs';
22

33
const hasRaf = typeof requestAnimationFrame === 'function';
44

@@ -25,7 +25,7 @@ const hasRaf = typeof requestAnimationFrame === 'function';
2525
* - **Mouse Scanning:** Hovering overrides the idle animation, creating a "Scanner" effect that snaps
2626
* to the nearest data point and displays precise values.
2727
*
28-
* @class DevRank.canvas.Sparkline
28+
* @class Neo.canvas.Sparkline
2929
* @extends Neo.core.Base
3030
* @singleton
3131
*/
@@ -53,10 +53,10 @@ class Sparkline extends Base {
5353

5454
static config = {
5555
/**
56-
* @member {String} className='DevRank.canvas.Sparkline'
56+
* @member {String} className='Neo.canvas.Sparkline'
5757
* @protected
5858
*/
59-
className: 'DevRank.canvas.Sparkline',
59+
className: 'Neo.canvas.Sparkline',
6060
/**
6161
* Remote method access
6262
* @member {Object} remote

src/canvas/_export.mjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import Sparkline from './Sparkline.mjs';
2+
3+
export {Sparkline};

src/component/Sparkline.mjs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ class Sparkline extends Canvas {
3535
ntype: 'sparkline',
3636
/**
3737
* The class name of the renderer to use in the worker.
38-
* @member {String|null} rendererClassName=null
38+
* @member {String} rendererClassName='Neo.canvas.Sparkline'
3939
*/
40-
rendererClassName: null,
40+
rendererClassName: 'Neo.canvas.Sparkline',
4141
/**
4242
* The import path for the renderer module.
43-
* @member {String|null} rendererImportPath=null
43+
* @member {String} rendererImportPath='src/canvas/Sparkline.mjs'
4444
*/
45-
rendererImportPath: null,
45+
rendererImportPath: 'src/canvas/Sparkline.mjs',
4646
/**
4747
* Controls the "Living Pulse" animation.
4848
* Set to `false` to disable the background animation.

0 commit comments

Comments
 (0)