Implement Centralized Logger for MCP Servers #7534

Author: tobiu

.github/ISSUE/ticket-mcp-server-logging.md

@@ -3,9 +3,8 @@ title: Implement Centralized Logger for MCP Servers
 labels: enhancement, AI
 ---
 
-GH ticket id: #(TBD)
+GH ticket id: #7534
 
-**Epic:** Architect AI Tooling as MCP
 **Assignee:** tobiu
 **Status:** Done
 

.github/ISSUE/ticket-tool-service-enhancement.md

@@ -0,0 +1,23 @@
+---
+title: Enhance MCP ToolService to Support OpenAPI Keywords
+labels: enhancement, AI
+---
+
+GH ticket id: #7535
+
+**Assignee:** tobiu
+**Status:** Done
+
+## Description
+
+The `ai/mcp/server/toolService.mjs` is responsible for parsing OpenAPI specifications and generating Zod schemas for validating tool inputs and outputs. The current implementation of `buildZodSchemaFromResponse` is too simplistic and does not support common OpenAPI keywords like `oneOf`, `required`, and `nullable`. This leads to schema validation errors when the OpenAPI spec uses these features.
+
+This ticket is to enhance the `buildZodSchemaFromResponse` function to correctly handle these keywords, making the tool service more robust and compliant with the OpenAPI specification.
+
+## Acceptance Criteria
+
+1.  The `buildZodSchemaFromResponse` function in `ai/mcp/server/toolService.mjs` is updated to handle the `oneOf` keyword by mapping it to Zod's `z.union`.
+2.  The function is updated to handle the `required` keyword for object properties, making properties optional in the Zod schema if they are not in the `required` list.
+3.  The function is updated to handle `nullable: true` by applying `.nullable()` to the Zod schema.
+4.  The `openapi.yaml` for the memory-core server is simplified to use `nullable: true` for the `pid` property, removing the need for complex `oneOf` constructs.
+5.  The `neo-memory-core__healthcheck` tool passes successfully with these changes.

ai/mcp/server/memory-core/openapi.yaml

@@ -503,7 +503,11 @@ components:
                   example: true
                 pid:
                   type: integer
+                  nullable: true
                   example: 12345
+                managed:
+                  type: boolean
+                  example: true
             connection:
               type: object
               properties:

ai/mcp/server/toolService.mjs

@@ -106,12 +106,22 @@ function buildZodSchemaFromResponse(doc, schema) {
         return buildZodSchemaFromResponse(doc, resolveRef(doc, schema.$ref));
     }
 
+    if (schema.oneOf) {
+        const options = schema.oneOf.map(s => buildZodSchemaFromResponse(doc, s));
+        return z.union(options);
+    }
+
     let zodSchema;
     if (schema.type === 'object') {
         const shape = {};
         if (schema.properties) {
+            const required = schema.required || [];
             for (const [propName, propSchema] of Object.entries(schema.properties)) {
-                shape[propName] = buildZodSchemaFromResponse(doc, propSchema);
+                let propertySchema = buildZodSchemaFromResponse(doc, propSchema);
+                if (!required.includes(propName)) {
+                    propertySchema = propertySchema.optional();
+                }
+                shape[propName] = propertySchema;
             }
         }
         zodSchema = z.object(shape);
@@ -127,6 +137,10 @@ function buildZodSchemaFromResponse(doc, schema) {
         zodSchema = z.any();
     }
 
+    if (schema.nullable) {
+        zodSchema = zodSchema.nullable();
+    }
+
     if (schema.description) {
         zodSchema = zodSchema.describe(schema.description);
     }