Skip to content

Commit fb8ec52

Browse files
committed
vdom.Helper: createVnode() => add support for vdom.text => vnode.textContent #6813
1 parent 2d942c4 commit fb8ec52

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

src/vdom/Helper.mjs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -295,17 +295,16 @@ class Helper extends Base {
295295
return null
296296
}
297297

298-
if (typeof opts === 'string') {
299-
300-
}
301-
302298
if (opts.vtype === 'text') {
303299
if (!opts.id) {
304300
opts.id = Neo.getId('vtext') // adding an id to be able to find vtype='text' items inside the vnode tree
305301
}
306302

307-
opts.innerHTML = `<!-- ${opts.id} -->${opts.html || ''}<!-- /neo-vtext -->`;
303+
const content = opts.html || opts.text || '';
304+
305+
opts.innerHTML = `<!-- ${opts.id} -->${content}<!-- /neo-vtext -->`;
308306
delete opts.html;
307+
delete opts.text;
309308
return opts
310309
}
311310

@@ -318,9 +317,9 @@ class Helper extends Base {
318317
}
319318

320319
Object.entries(opts).forEach(([key, value]) => {
321-
let hasUnit, newValue, style;
320+
if (value !== undefined && value !== null && key !== 'flag' && key !== 'removeDom') {
321+
let hasUnit, newValue, style;
322322

323-
if (value !== undefined && value !== null && key !== 'flag') {
324323
switch (key) {
325324
case 'tag':
326325
case 'nodeName':
@@ -330,6 +329,9 @@ class Helper extends Base {
330329
case 'innerHTML':
331330
node.innerHTML = value.toString(); // support for numbers
332331
break
332+
case 'text':
333+
node.textContent = value
334+
break
333335
case 'children':
334336
case 'childNodes':
335337
case 'cn':
@@ -393,9 +395,7 @@ class Helper extends Base {
393395
}
394396
break
395397
default:
396-
if (key !== 'removeDom') { // could be set to false
397-
node.attributes[key] = value + ''
398-
}
398+
node.attributes[key] = value + '';
399399
break
400400
}
401401
}

0 commit comments

Comments
 (0)