-
Notifications
You must be signed in to change notification settings - Fork 853
[proxy] replace the batch cancellation queue, shorten the TTL for cancel keys #11943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8492 tests run: 7911 passed, 0 failed, 581 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
02cd4c1 at 2025-06-20T11:31:58.011Z :recycle: |
882d238 to
f808ba9
Compare
3247439 to
1e0b22b
Compare
d1ebb55 to
3370e8c
Compare
b509982 to
7c469b3
Compare
2c5e757 to
02cd4c1
Compare
awarus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks way better than we had before. Nevertheless, I think we should run it in staging with some prod-like load before releasing
|
Yeah, I at least ran it in staging to verify the cancellation works after 10 minutes (it does work). We would need to hit it with high connection request rate to verify (I can give that a go in a moment) |
|
I'll merge now so it stays in staging. I'll run some tests (useful now that we can edit our rate limits :D) |
See #11942
Idea:
intrusive linked listsBTreeMap.