Domain client for Pageserver GRPC. #12111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8492 tests run: 7910 passed, 0 failed, 582 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
1155dd4 at 2025-06-18T15:52:08.083Z :recycle: |
erikgrinaker
reviewed
Jun 3, 2025
erikgrinaker
reviewed
Jun 3, 2025
erikgrinaker
reviewed
Jun 4, 2025
Contributor
|
Could you please resolve and/or respond to comments as they're addressed, and mark this PR as ready for review when CI passes and it's ready for a final look? I suggest running |
Contributor
There was a problem hiding this comment.
Thanks! This mostly LGTM, with a few minor issues and a bunch of nits. It should also have a proper PR message.
Just to be clear: nits are optional, and for your consideration -- take them or leave them. I won't harp on about all of this in later PRs, but am pointing them out once.
erikgrinaker
approved these changes
Jun 18, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
## Problem The gRPC page service should support compression. Requires #12111. Touches #11728. Touches neondatabase/neon-archive-cloud#25679. ## Summary of changes Add support for gzip and zstd compression in the server, and a client parameter to enable compression. This will need further benchmarking under realistic network conditions.
erikgrinaker
pushed a commit
that referenced
this pull request
Jun 19, 2025
Add domain client for new communicator GRPC types.
erikgrinaker
added a commit
that referenced
this pull request
Jun 19, 2025
## Problem The gRPC page service should support compression. Requires #12111. Touches #11728. Touches neondatabase/neon-archive-cloud#25679. ## Summary of changes Add support for gzip and zstd compression in the server, and a client parameter to enable compression. This will need further benchmarking under realistic network conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add domain client for new communicator GRPC types.