Skip to content

Change the unit of cluster size limit GUC to MB, and other fixes. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hlinnaka merged 1 commit into from
Feb 9, 2022
Merged

Change the unit of cluster size limit GUC to MB, and other fixes. #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/zenith/libpagestore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,9 @@ _PG_init(void)
"cluster size limit",
NULL,
&max_cluster_size,
-1, -1, MAX_KILOBYTES,
-1, -1, INT_MAX,
PGC_SIGHUP,
GUC_UNIT_BYTE,
GUC_UNIT_MB,
NULL, NULL, NULL);

relsize_hash_init();
Expand Down
38 changes: 14 additions & 24 deletions contrib/zenith/pagestore_smgr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,6 @@ zenith_extend(SMgrRelation reln, ForkNumber forkNum, BlockNumber blkno,
char *buffer, bool skipFsync)
{
XLogRecPtr lsn;
uint64 current_instance_size;

switch (reln->smgr_relpersistence)
{
Expand All @@ -783,33 +782,24 @@ zenith_extend(SMgrRelation reln, ForkNumber forkNum, BlockNumber blkno,
elog(ERROR, "unknown relpersistence '%c'", reln->smgr_relpersistence);
}

current_instance_size = GetZenithCurrentClusterSize();

// Do not limit autovacuum processes.
if (!IsAutoVacuumWorkerProcess() && max_cluster_size > 0)
/*
* Check that the cluster size limit has not been exceeded.
*
* Temporary and unlogged relations are not included in the cluster size measured
* by the page server, so ignore those. Autovacuum processes are also exempt.
*/
if (max_cluster_size > 0 &&
reln->smgr_relpersistence == RELPERSISTENCE_PERMANENT &&
!IsAutoVacuumWorkerProcess())
{
if (current_instance_size >= max_cluster_size)
uint64 current_size = GetZenithCurrentClusterSize();

if (current_size >= ((uint64) max_cluster_size) * 1024 * 1024)
ereport(ERROR,
(errcode(ERRCODE_DISK_FULL),
errmsg("could not extend file. Cluster size limit of %d bytes is reached",
max_cluster_size),
errhint("This limit is defined by zenith.max_cluster_size GUC")));
// Throw a warning if current size is too close to the limit.
// `too close' is now defined as 10%
else if (current_instance_size >= max_cluster_size*0.1)
{
ereport(WARNING,
(errmsg("Current cluster size %lu bytes is close to the limit of %d bytes. ",
current_instance_size, max_cluster_size),
errmsg("could not extend file because cluster size limit (%d MB) has been exceeded",
max_cluster_size),
errhint("This limit is defined by zenith.max_cluster_size GUC")));
}
else
{
ereport(WARNING,
(errmsg("Current cluster size %lu bytes is not close to the limit of %d bytes. ",
current_instance_size, max_cluster_size),
errhint("This limit is defined by zenith.max_cluster_size GUC")));
}
}

zenith_wallog_page(reln, forkNum, blkno, buffer);
Expand Down