Add on-demand WAL download in CreateReplicationSlot (v14) #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knizhnik
approved these changes
Sep 3, 2024
hlinnaka
added a commit
that referenced
this pull request
Sep 4, 2024
This reverts commit d48d08d. Reason: This was accidentally only committed to the REL_14_STABLE_neon branch, even though we need the same change in all Postgres versions. And the merged PR was a few bricks shy of a load: there were more changes on the v16 PR than the v15 and v14 PRs. Also, there were no tests. To get us back to a known good state, revert this now. Later, write tests, and open a new set of PRs for all the branches.
hlinnaka
added a commit
that referenced
this pull request
Sep 4, 2024
This reverts commit d48d08d. Reason: This was accidentally only committed to the REL_14_STABLE_neon branch, even though we need the same change in all Postgres versions. And the submodule reference in the 'neon' repository was never updated, so we never actually shipped this change. The merged PR was a few bricks shy of a load: there were more changes on the v16 PR than the v15 and v14 PRs. Also, there were no tests. To get us back to a known good state, revert this now. Later, write tests, and open a new set of PRs for all the branches.
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Sep 4, 2024
There was a confusion on the REL_14_STABLE_neon branch. PR neondatabase/postgres#471 was merged ot the branch, but the corresponding PRs on the other REL_15_STABLE_neon and REL_16_STABLE_neon branches were not merged. Also, the submodule reference in the neon repository was never updated, so even though the REL_14_STABLE_neon branch contained the commit, it was never used. That PR neondatabase/postgres#471 was a few bricks shy of a load (no tests, some differences between the different branches), so to get us to a good state, revert that change from the REL_14_STABLE_neon branch. This PR in the neon repository updates the submodule reference past two commites on the REL_14_STABLE_neon branch: first the commit from PR neondatabase/postgres#471, and immediately after that the revert of the same commit. This brings us back to square one, but now the submodule reference matches the tip of the REL_14_STABLE_neon branch again.
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Sep 4, 2024
There was a confusion on the REL_14_STABLE_neon branch. PR neondatabase/postgres#471 was merged ot the branch, but the corresponding PRs on the other REL_15_STABLE_neon and REL_16_STABLE_neon branches were not merged. Also, the submodule reference in the neon repository was never updated, so even though the REL_14_STABLE_neon branch contained the commit, it was never used. That PR neondatabase/postgres#471 was a few bricks shy of a load (no tests, some differences between the different branches), so to get us to a good state, revert that change from the REL_14_STABLE_neon branch. This PR in the neon repository updates the submodule reference past two commites on the REL_14_STABLE_neon branch: first the commit from PR neondatabase/postgres#471, and immediately after that the revert of the same commit. This brings us back to square one, but now the submodule reference matches the tip of the REL_14_STABLE_neon branch again.
tristan957
pushed a commit
that referenced
this pull request
Sep 11, 2024
This reverts commit d48d08d. Reason: This was accidentally only committed to the REL_14_STABLE_neon branch, even though we need the same change in all Postgres versions. And the submodule reference in the 'neon' repository was never updated, so we never actually shipped this change. The merged PR was a few bricks shy of a load: there were more changes on the v16 PR than the v15 and v14 PRs. Also, there were no tests. To get us back to a known good state, revert this now. Later, write tests, and open a new set of PRs for all the branches.
tristan957
pushed a commit
that referenced
this pull request
Sep 11, 2024
This reverts commit d48d08d. Reason: This was accidentally only committed to the REL_14_STABLE_neon branch, even though we need the same change in all Postgres versions. And the submodule reference in the 'neon' repository was never updated, so we never actually shipped this change. The merged PR was a few bricks shy of a load: there were more changes on the v16 PR than the v15 and v14 PRs. Also, there were no tests. To get us back to a known good state, revert this now. Later, write tests, and open a new set of PRs for all the branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.