Check for invalid down link while prefetching B-Tree leave pages for index-only scan #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMeent
reviewed
Nov 27, 2024
Comment on lines
893
to
894
| else if (!BlockNumberIsValid(so->next_parent)) | ||
| elog(FATAL, "btpo_next is invalid"); |
Contributor
There was a problem hiding this comment.
opaque->ptpo_next can be P_NONE, but IIUC that is 0, not InvalidBlockNumber. I don't understand how it could be InvalidBlockNumber.
Contributor
There was a problem hiding this comment.
While the check isn't wrong per se, I think this is irrelevant as btpo_prev shouldn't be InvalidBlockNumber, ever.
Same comment on the same addition around line 908-912 - I think both can be reverted.
knizhnik
force-pushed
the
ios_prefetch_fix_v17
branch
from
4fc8da9 to
424b5ba
Compare
MMeent
reviewed
Dec 11, 2024
Contributor
MMeent
left a comment
MMeent
left a comment
There was a problem hiding this comment.
I think this is an improvement over the previous version, but seems to have some additions that I'd rather see gone.
Comment on lines
893
to
894
| else if (!BlockNumberIsValid(so->next_parent)) | ||
| elog(FATAL, "btpo_next is invalid"); |
Contributor
There was a problem hiding this comment.
While the check isn't wrong per se, I think this is irrelevant as btpo_prev shouldn't be InvalidBlockNumber, ever.
Same comment on the same addition around line 908-912 - I think both can be reverted.
knizhnik
force-pushed
the
ios_prefetch_fix_v17
branch
from
398fb77 to
9b1bcff
Compare
MMeent
approved these changes
Dec 13, 2024
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Dec 13, 2024
…index-only scan (#9867) ## Problem See #9866 Index-only scan prefetch implementation doesn't take in account that down link may be invalid ## Summary of changes Check that downlink is valid block number Correspondent Postgres PRs: neondatabase/postgres#534 neondatabase/postgres#535 neondatabase/postgres#536 neondatabase/postgres#537 --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
lubennikovaav
pushed a commit
that referenced
this pull request
May 9, 2025
…index-only scan (#534) * Check for invalid down link while prefetching B-Tree leave pages for index-only scan * Replace assert which doesn't take in account presence of invalid downlinks * Replace assert which doesn't take in account presence of invalid downlinks * Add extra checks for IOS prefetch * Do not use stack->bts_offset because content of parent page can be changed * Remove unintended changes --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
MMeent
pushed a commit
that referenced
this pull request
Jul 3, 2025
…index-only scan (#534) * Check for invalid down link while prefetching B-Tree leave pages for index-only scan * Replace assert which doesn't take in account presence of invalid downlinks * Replace assert which doesn't take in account presence of invalid downlinks * Add extra checks for IOS prefetch * Do not use stack->bts_offset because content of parent page can be changed * Remove unintended changes --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.