Emit nbtree vacuum cycle id in nbtree xlog through FPIs #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMeent
force-pushed
the
MMeent/fix/btree-split-cycle-v17
branch
4 times, most recently
from
31f850d to
4d4b647
Compare
hlinnaka
reviewed
Dec 2, 2024
MMeent
force-pushed
the
MMeent/fix/btree-split-cycle-v17
branch
from
4d4b647 to
c459d51
Compare
hlinnaka
approved these changes
Dec 4, 2024
MMeent
force-pushed
the
MMeent/fix/btree-split-cycle-v17
branch
from
c459d51 to
ed38f0b
Compare
NBTree needs a vacuum cycle ID on pages of whom the split resulted in a new right page that is located before the original page, or who were split from such split pages in the current vacuum cycle. By WAL-logging the cycle_id and restoring it in recovery, we assure vacuum doesn't fail to clean up the earlier pages. During recovery, we extract the cycle ID from the original page if this page had an FPI, either directly (when the page was restored) or indirectly (from the record data). This fixes neondatabase/neon#9929
MMeent
force-pushed
the
MMeent/fix/btree-split-cycle-v17
branch
from
ed38f0b to
add31fa
Compare
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Dec 10, 2024
This fixes #9929. ## Postgres repo PRS: - PG17: neondatabase/postgres#538 - PG16: neondatabase/postgres#539 - PG15: neondatabase/postgres#540 - PG14: neondatabase/postgres#541 ## Problem see #9929 ## Summary of changes We update the split code to force the code to emit an FPI whenever the cycle ID might be interesting for concurrent btree vacuum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the PostgreSQL v17 side of neondatabase/neon#9929.
See also: neondatabase/neon#9932