Skip to content

Online repl checkpoint #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knizhnik merged 3 commits into from
Dec 18, 2024
Merged

Online repl checkpoint #546

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e29d64b
Online checkpoint replication state
knizhnik Dec 3, 2024
21f9464
Fix int->bool conversion
knizhnik Dec 3, 2024
7e3f397
Prevent duble call of CheckPointReplicationState
knizhnik Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions src/backend/access/transam/xlog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7993,16 +7993,11 @@ CreateOverwriteContrecordRecord(XLogRecPtr aborted_lsn, XLogRecPtr pagePtr,
static void
CheckPointReplicationState(int flags)
{
if (flags & CHECKPOINT_IS_SHUTDOWN)
{
CheckPointRelationMap();
CheckPointReplicationSlots(true);
CheckPointSnapBuild();
CheckPointLogicalRewriteHeap();
CheckPointReplicationOrigin();
}
else
CheckPointReplicationSlots(false);
CheckPointRelationMap();
CheckPointReplicationSlots((flags & CHECKPOINT_IS_SHUTDOWN) != 0);
CheckPointSnapBuild();
CheckPointLogicalRewriteHeap();
CheckPointReplicationOrigin();
}

/*
Expand All @@ -8026,7 +8021,8 @@ PreCheckPointGuts(int flags)
static void
CheckPointGuts(XLogRecPtr checkPointRedo, int flags)
{
CheckPointReplicationState(flags);
if (!(flags & CHECKPOINT_IS_SHUTDOWN))
CheckPointReplicationState(flags);

/* Write out all dirty data in SLRUs and the main buffer pool */
TRACE_POSTGRESQL_BUFFER_CHECKPOINT_START(flags);
Expand Down