Pgstat aux file v17 #547
Merged
Pgstat aux file v17 #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinnaka
reviewed
Dec 10, 2024
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
2 times, most recently
from
327b80b to
55b44ec
Compare
hlinnaka
reviewed
Dec 17, 2024
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
from
c83b703 to
27ca388
Compare
hlinnaka
reviewed
Jan 13, 2025
hlinnaka
reviewed
Jan 13, 2025
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
from
0cdc60c to
b370789
Compare
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
from
b370789 to
e712066
Compare
hlinnaka
approved these changes
Jan 28, 2025
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
2 times, most recently
from
c853efe to
e07a163
Compare
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
2 times, most recently
from
05e5372 to
bb6be5f
Compare
hlinnaka
reviewed
Feb 14, 2025
hlinnaka
reviewed
Feb 14, 2025
hlinnaka
reviewed
Feb 14, 2025
hlinnaka
reviewed
Feb 14, 2025
hlinnaka
reviewed
Feb 14, 2025
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
2 times, most recently
from
05eb426 to
f6ea453
Compare
Do not wallog AUX files at replica Update src/backend/replication/logical/message.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Update src/backend/replication/logical/message.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Add wallog_file_removal function Do small refactoring Update src/backend/replication/logical/message.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Update src/backend/access/heap/rewriteheap.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Address review comments Address review comments Do no touch file position in wallog_file_descriptor Add include header for fstat Fix indentation amd mistypings Increase neon_pgstat_file_size_limit to 8Mb Update src/backend/access/transam/xlog.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Fix indentation Do not wallog pgstat file if neon_pgstat_file_size_limit is zero Increase default value of neon_pgstat_file_size_limit to 16Mb Update src/backend/access/transam/xlog.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Update src/backend/access/heap/rewriteheap.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Update src/backend/replication/logical/message.c Co-authored-by: Heikki Linnakangas <heikki@neon.tech> Address review comments Disable persisting pgstat file by default
knizhnik
force-pushed
the
pgstat_aux_file_v17
branch
from
f6ea453 to
59b2fe8
Compare
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Feb 20, 2025
## Problem Statistic is saved in local file and so lost on compute restart. Persist in in page server using the same AUX file mechanism used for replication slots See more about motivation in https://neondb.slack.com/archives/C04DGM6SMTM/p1703077676522789 ## Summary of changes Persist postal file using AUX mechanism Postgres PRs: neondatabase/postgres#547 neondatabase/postgres#446 neondatabase/postgres#445 Related to #6684 and #6228 Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.