Do not assign max(lsn) to maxLastWrittenLsn in SetLastWrittenLSNForBlockv #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMeent
reviewed
Jan 22, 2025
Comment on lines
-6988
to
-6989
| if (max > XLogCtl->maxLastWrittenLsn) | ||
| XLogCtl->maxLastWrittenLsn = max; |
Contributor
There was a problem hiding this comment.
if XLogCtl->maxLastWrittenLsn isn't the maximum of all lastWrittenLsns, then what is it?
Author
There was a problem hiding this comment.
It is maximal last written LSN of pages not present in the cache.
So this value is used for page not found in the LwLSN cache.
MMeent
approved these changes
Jan 24, 2025
knizhnik
force-pushed
the
fix_set_lwlsnv
branch
from
f662727 to
46f9b96
Compare
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Jan 24, 2025
…okv (#10474) ## Problem See #10281 `SetLastWrittenLSNForBlockv` is assigning max(lsn) to `maxLastWrittenLsn` while its should contain only max LSN not present in LwLSN cache. It case unnecessary waits in PS. ## Summary of changes Restore status-quo for pg17. Related Postgres PR: neondatabase/postgres#563 --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.